From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AE5F37F72D for ; Wed, 14 Jan 2026 08:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768378838; cv=none; b=cNwE4vrzbhqoW9JEyVBCuREci8+dGyLUnVAxjfphg7VR+C5tXdYaZ+cNTnh4W6vPHp2N9yJxAohpAqkVqRGip6P3WybDVxUxJ/eTq5nCSgaQwwZ+LWhEcD6EMsVC+lTKIeSVUhLVI4YAE5jarfOdn7FbNT+9OYCeP0wnmPha0DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768378838; c=relaxed/simple; bh=cVeFdKo0k7nGdWRXnAwflkhPHd9OUkqReF3689rtABc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MGZ+r0xvfdubRvCrHcTWa9MW9gCs51ptCYe1ilsoJLKm+1eX0Q8E2vJZE+299wKj2cXkNV1IvLjhO3SC8ipUoiyGj7SZ1ty/hADmSpcKijsH0hew5ksqygI/7dqYDyC5iJ+qPp1czvPlaKZ/KuCpNW+ThMYmlIuuVzWim1y26Fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HAqBZOWJ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HAqBZOWJ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4327555464cso5005563f8f.1 for ; Wed, 14 Jan 2026 00:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768378824; x=1768983624; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kOjWICKElajAktcnLTxDO0a0hjOrXuTPJG+TIiIDMlE=; b=HAqBZOWJEIe4297o2nch9K7sfY2e3rwSW4KHYoclvUMAcEcNUg91l/u9/l2DhoiKDh 5mQ4Tmk8jFbK+/ztvvC3fxPmXlgYD014LA9iSPLwBDMuy8spbBC9T3FxGQkvef8OP8yL 5krZhcAQbya3VX03HlBzNsj5j1anLNi/SLLzwCVbgydydZrz9pEmavTs0dhxYagPzWPj vZBG6qWsx5kDlz0+Tvb7GqDpEQKTyncmmIMrZ5k0T2lHxekITQnL8QuQx/vLfEIhqPca Dpt5fKyRvxPTTBOTsr8GTUOiBe9YP3PjjL0zcPKr4ijCiy8fYXe+4Q1ggtB4RE1/+Bq5 1o/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768378824; x=1768983624; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kOjWICKElajAktcnLTxDO0a0hjOrXuTPJG+TIiIDMlE=; b=JLCpTNLraxvV0KM0QVl2GaoMr1GFLQB/G/3w3MJIFK0Z8bndpVA/qDoYIFv3u6IRV5 ggfom37GyBJOKZ5HlV0I6q2z4m7eb7zIg6V5zhPoKbmSLM0IKfTh5q7u5Bm19kexmO5z nzxNG+Wqx6j5LnY0B9hXC4WxlJHpZjVMFPiDlwvQXN8U/zCYtFF1wXXzElCLuiKKRWKL Id00ESVY/oawoefBwU0uT8+9jvCH5i3MVv2j81u/iNzKAoktdZDOjT6qiXViNo0LTOXx VyMVvwNNKl2A8NlXRuo6Ejzus8YVtgEDW5rHxJghilYNAw9ae1bwxahjtQfV3koBB5wR Yq4g== X-Forwarded-Encrypted: i=1; AJvYcCXsLAw0zcxgWXc8QUO4VHrIQFEVbiPbigt/MnXAZ9mPvDeyYn5sknWjdXP7d9/1dSZw9rdfG8cI3+ta104eItE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0v9Ez1jjqgEZ3MgkFSdOMXPlihgPWfMCccRuWaBhB/fh1b1Kw fJ+BDPa88aJZPOsy+QeBaEjAe1OW7YFOa94HVwKiikQ6FtxdtzvqqGNnCkfxQVFlo/s= X-Gm-Gg: AY/fxX6PGRE4r2ujQ72evTj/SEpup8wfMit67zD8M/CS6Uc0yA7zJfuxv7TZrL7OBcc r4SB7gzyD9ZLgHzXA5mxR0Ej5ZaBRKjBQSaq0TCFyS5nr8rPSExzDlFH5RjeXCV2YRynOGaHXh4 0EpbRTSuMUhAXXGQtoX3hjZRjlbiLw7pg8ON0/zsmoQtNr2eSNf/wr/akB8/T7VfvKMoXFxWJmQ /g4WZAK3NR7Hogj0BXVdCboAD8L5jIzTSix/24jCGXLzYj/jc8X8kqbYIk9CQsb1w4ilttHKMyr 3wVoXK7H8zkWU3oXm59U+4BfATuyun3Vlk7SN9uYEMCkweLw7e2ntUOTje1uBOjN3e8IebEbvcT Nce22NwXTk1zs0xM5SY1B7TaE/uhJtxcImd4jvb9DKK3Rcwo+sMtyRCwi0z8UqEpZ78jbWn5KhO bxlIroH3DrgJWW0g== X-Received: by 2002:a05:6000:40e1:b0:432:5b81:498 with SMTP id ffacd0b85a97d-4342c4f4a32mr1782744f8f.23.1768378823922; Wed, 14 Jan 2026 00:20:23 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dad8bsm49346913f8f.8.2026.01.14.00.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 00:20:23 -0800 (PST) Date: Wed, 14 Jan 2026 09:20:20 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Daniel Thompson , Richard Weinberger , Anton Ivanov , Johannes Berg , Greg Kroah-Hartman , Jason Wessel , Daniel Thompson , Douglas Anderson , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jiri Slaby , Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Andreas Larsson , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Jacky Huang , Shan-Chun Hung , Laurentiu Tudor , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hardening@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 00/19] printk cleanup - part 3 Message-ID: References: <20251227-printk-cleanup-part3-v1-0-21a291bcf197@suse.com> <89409a0f48e6998ff6dd2245691b9954f0e1e435.camel@suse.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <89409a0f48e6998ff6dd2245691b9954f0e1e435.camel@suse.com> On Tue 2026-01-13 21:32:33, Marcos Paulo de Souza wrote: > On Tue, 2026-01-13 at 09:41 -0300, Marcos Paulo de Souza wrote: > > On Mon, 2026-01-05 at 14:08 +0000, Daniel Thompson wrote: > > > On Mon, Jan 05, 2026 at 12:52:14PM +0000, Daniel Thompson wrote: > > > > Hi Marcos > > > > > > > > On Sat, Dec 27, 2025 at 09:16:07AM -0300, Marcos Paulo de Souza > > > > wrote: > > > > > The parts 1 and 2 can be found here [1] and here[2]. > > > > > > > > > > The changes proposed in this part 3 are mostly to clarify the > > > > > usage of > > > > > the interfaces for NBCON, and use the printk helpers more > > > > > broadly. > > > > > Besides it, it also introduces a new way to register consoles > > > > > and drop thes the CON_ENABLED flag. It seems too much, but in > > > > > reality > > > > > the changes are not complex, and as the title says, it's > > > > > basically a > > > > > cleanup without changing the functional changes. > > > > > > > > I ran this patchset through the kgdb test suite and I'm afraid it > > > > is > > > > reporting functional changes. > > > > > > > > Specifically the earlycon support for kdb has regressed (FWIW the > > > > problem bisects down to the final patch in the series where > > > > CON_ENABLED > > > > is removed). > > > > > > > > Reproduction on x86-64 KVM outside of the test suite should be > > > > easy: > > > > > > > >     make defconfig > > > >     scripts/config \ > > > >         --enable DEBUG_INFO \ > > > > --enable DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT \ > > > > --enable DEBUG_FS \ > > > > --enable KALLSYMS_ALL \ > > > > --enable MAGIC_SYSRQ \ > > > > --enable KGDB \ > > > > --enable KGDB_TESTS \ > > > > --enable KGDB_KDB \ > > > > --enable KDB_KEYBOARD \ > > > > --enable LKDTM \ > > > > --enable SECURITY_LOCKDOWN_LSM > > > >     make olddefconfig > > > >     make -j$(nproc) > > > >     qemu-system-x86_64 \ > > > >         -m 1G -smp 2 -nographic \ > > > > -kernel arch/x86/boot/bzImage \ > > > > -append "console=ttyS0,115200 kgdboc=ttyS0 > > > > earlycon=uart8250,io,0x3f8 kgdboc_earlycon kgdbwait" > > > > > > Actually I realized there was a simpler reproduction (hinted at by > > > the > > > missing "printk: legacy bootconsole [uart8250] enabled" in the > > > regressed > > > case). It looks like the earlycon simply doesn't work and that > > > means > > > the > > > reproduction doesn't require anything related to kgdb at all. > > > Simply: > > > > > >     make defconfig > > >     make -j$(nproc) > > >     qemu-system-x86_64 -m 1G -smp 2 -nographic -kernel > > > arch/x86/boot/bzImage \ > > >         -append "earlycon=uart8250,io,0x3f8" > > > > > > With the part 3 patchset applied I get no output from the earlycon > > > (without the patch set I get the early boot messages which, as > > > expected, > > > stop when tty0 comes up). > > > > Hi Daniel, sorry for the late reply! Lots of things to check lately > > :) > > > > Ok, I reproduced here, thanks a lot for testing kgdboc, it's a quick > > way to check that the new register_console_force is not working. Let > > me > > take a look to find what's wrong. Thanks a lot for finding this > > issue! > > Ok, I did a bisect and found out that the issue lies in the last > commit, where CON_ENABLED was removed. After it, I then checked what > was wrong, since everything was being plumbed correctly (tm), and then > I found that it was not: > > On _register_console, the function try_enable_default_console is called > when there are not registered consoles, and then it sets CON_ENABLED > for the console. Later on, try_enable_preferred_console it checks if > the console was specified by the user, and at the same time it had > CON_ENABLED set. > > It worked by chance, but now, we don't have this flag anymore, and then > we are not _marking_ the console on try_enable_default_console so > try_enable_preferred_console returns ENOENT. Great catch! Yeah, it worked just by chance. > So, without any console kgdb is activated much later in the boot > process, as you found it. > > I talked with Petr Mladek and it would need to rework the way that we > register a console, and he's already working on it. Yes, I have some patches in early stages of developnent of another feature which would help here. > For now I believe > that we could take a look in all the patches besides the last one that > currently breaks the earlycon with kgdb and maybe other usecases. I agree. I am going to review this patchset first. Then I'll try to clean up the patches which remove the ugly side effect from try_enable_preferred_console(). Then we could discuss how to move forward. It might make sense to push this patchset first without the last patch... > Sorry for not catching this issue before. I'll use kgdb next time to > make sure that it keeps working :) Do not worry at all. It was a well hidden catch. It is great that Daniel found the regression in time... Best Regards, Petr