From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3DD3B9613 for ; Thu, 15 Jan 2026 16:28:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494534; cv=none; b=jngueJ3WaQPPopwRDlHULJfyNr0SPb/JI3/XZya010LvE07j+ReLPJySP4htICvCKqAWayEs8GjfaYtUsIaflsRt2IHvwws4XbgdiXKR3wvG80I4I0lxer40i1zrzaz8icNRI1zHoA7XeZzMGWiGndFJ0BWdA9P4G9jr3BnloTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768494534; c=relaxed/simple; bh=JFb4SbeyltssbTkVrC2fePq+++qLD9rMapcGslFduHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SHsJDH81oLL1ZqoSGl3ew8bCPiLNvvvFswlC8w8HihTIVgs9fpqfVvhZGJpolTX/jUVfR2Y2tnSGf0KrfwulBtBZ9kKgJcea6PTCvElmkhz1ccGNNpXNnKw18rv95bB4EoshRkzW+G5d8VsHdNYXVZRN+3qcQTenYH6+pMQl2p8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PPZfacP/; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PPZfacP/" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so967718f8f.2 for ; Thu, 15 Jan 2026 08:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768494529; x=1769099329; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=URJX5xTHolO9FC46ryjpGruJ5TGEDEyfrbwATuqwgLQ=; b=PPZfacP/bGzplc0450JH455dYiEUnNfUxQqSjlpjqIKonKjZZywOVZdLqzEqshSlls Ng7iaUezeoXcgC+iB7m0WMJ6ykwFWxA8At1owBUUOwZAxNVxjbgWzjhlXwNMYvqZi2OE 1qLM/T5yL/TBaIDqILptRNIvkdq6D6rKbWpYKWU4BDWKEnYE4+NZWzUF6Y9lq57tHzDw Axkb44kDQ4rki3qmMn5r1sROBVEhjCLZfJOCj4iqJnE0/pl5vp5aJ9SiE7GDxUnHkjis zWUX/6b8cJF2C2PSJU45/ekSzDP88TQ0YgX721XUAeD0HKGBg8j+H+zy+GVab8afwPsu 0QUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768494529; x=1769099329; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=URJX5xTHolO9FC46ryjpGruJ5TGEDEyfrbwATuqwgLQ=; b=cWqeb12fNJJPdR77F+uowTFpyHfP4v3odZlr513Mn15JoBa/enjBpaD278ebcAw6qL z5h4p03z+9PCl54eWUVhu2kNXjYb1yuTXHRipcgk8PuBF0Cdznt4oF45tmfJjdMYDx1O 9qEYwXRyVU2dxiJ1zo0ig8nbRAX7p93k1ldzqZnx+qDQDSH88pfInNwzeNUTlD8NlrwU cXO1LYvc54ylIdlUulAGJDkhHigys/JBn0ItE9UHzXokDahkaG6plq+ZHARRsfrr+mLz GVC0whAgyp7LHn2EQcl1qwToNonYP2SkO+8ruM8dBiUNX8vP+N8swKYjzU5V36d/CJeZ nU/g== X-Forwarded-Encrypted: i=1; AJvYcCXPyZtgUwyCsZLuG9ibgftVd8+s37tZ6fVObv/gn57i/OEqFSyO/VO2gpk3dD1P8gfiu5KcquRDjzOw4wfN69o=@vger.kernel.org X-Gm-Message-State: AOJu0YyGn54+krBTGmQ60Svj1S8+/qAKZdANhMfR9z+F23gw6X6TvnWz 2eVbAtTVrDOxX0vbff1Af3yKrV5xhsGJEalP8tMUMlzao/N4FQtnPU/fLEBbtU9zZwM= X-Gm-Gg: AY/fxX6myAsEOurtC0PFRYnfj+TzV8jLq/MBkcwXgkKSCl0g4/i4iS54oX9VDpIs+N2 1GJ/6wO07M7mfuxP3tXD2R2woiyOTUkpCWo80HA3iq3vpFKzOnKNpzvUefwX+ljD5TuSY1UpcDW BZB+wk9IUx03j+BGt64aseaFpGaNC2psdCcma/jqKSzm3AtJ8AigBwcb40syiPNcA2aiSudsv5J xBdyz3uy2YvfnQhKF8oR1LKfZCGo78FCz9owkGpU3kJg6LeR2lNCKoRaMdo3IGf1l+apKQDOgUf R5s52O6/X4oG7VinvnxloIBj5Ld5uBgScy4JxVRHBaiH0qEenN6rYGMTWbK3BeiYS6tdp5YYE4/ rfHCdIx6dizWXXn7t0XmD0oAQPClMqC9Nn6p1SCfdTczDSfiFaVyrQkjwnmaA7d49G3Vetes8yy 7RHNeVBnxxq8zz2g== X-Received: by 2002:a5d:64c5:0:b0:430:fd0f:2910 with SMTP id ffacd0b85a97d-4342c501a57mr9777353f8f.26.1768494528600; Thu, 15 Jan 2026 08:28:48 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af6e148bsm6604069f8f.33.2026.01.15.08.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 08:28:47 -0800 (PST) Date: Thu, 15 Jan 2026 17:28:44 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , Greg Kroah-Hartman , Jason Wessel , Daniel Thompson , Douglas Anderson , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jiri Slaby , Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Andreas Larsson , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Jacky Huang , Shan-Chun Hung , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hardening@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 16/19] drivers: tty: serial: ma35d1_serial: Migrate to register_console_force helper Message-ID: References: <20251227-printk-cleanup-part3-v1-0-21a291bcf197@suse.com> <20251227-printk-cleanup-part3-v1-16-21a291bcf197@suse.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251227-printk-cleanup-part3-v1-16-21a291bcf197@suse.com> On Sat 2025-12-27 09:16:23, Marcos Paulo de Souza wrote: > The register_console_force function was introduced to register consoles > even on the presence of default consoles, replacing the CON_ENABLE flag > that was forcing the same behavior. > > No functional changes. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/tty/serial/ma35d1_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c > index 285b0fe41a86..d1e03dee5579 100644 > --- a/drivers/tty/serial/ma35d1_serial.c > +++ b/drivers/tty/serial/ma35d1_serial.c > @@ -633,7 +633,7 @@ static struct console ma35d1serial_console = { > .write = ma35d1serial_console_write, > .device = uart_console_device, > .setup = ma35d1serial_console_setup, > - .flags = CON_PRINTBUFFER | CON_ENABLED, > + .flags = CON_PRINTBUFFER, > .index = -1, > .data = &ma35d1serial_reg, > }; > @@ -657,7 +657,7 @@ static void ma35d1serial_console_init_port(void) > static int __init ma35d1serial_console_init(void) > { > ma35d1serial_console_init_port(); > - register_console(&ma35d1serial_console); > + register_console_force(&ma35d1serial_console); Sigh, I am afraid that this is not enough. I double checked how "ma35d1serial_console" was used. I guess that it could get registered also via the generic uart device driver code. I see the following: #ifdef CONFIG_SERIAL_NUVOTON_MA35D1_CONSOLE [...] #define MA35D1SERIAL_CONSOLE (&ma35d1serial_console) #else #define MA35D1SERIAL_CONSOLE NULL #endif static struct uart_driver ma35d1serial_reg = { [...] .cons = MA35D1SERIAL_CONSOLE, [...] }; static int __init ma35d1serial_init(void) { [...] ret = uart_register_driver(&ma35d1serial_reg); [...] ret = platform_driver_register(&ma35d1serial_driver); [...] } And the gneric code: uart_configure_port(struct uart_driver *drv, struct uart_state *state, struct uart_port *port) { [...] /* * If this driver supports console, and it hasn't been * successfully registered yet, try to re-register it. * It may be that the port was not available. */ if (port->cons && !console_is_registered(port->cons)) register_console(port->cons); [...] } , which can called via from: + mux_probe() + uart_add_one_port() + serial_ctrl_register_port() +serial_core_register_port() + serial_core_add_one_port() + uart_configure_port() + register_console() Honestly, I am not 100% sure. The struct console is assigned to .cons in struct uart_driver. And uart_configure_port() function passes port->cons from struct uart_port *port. But I believe that they can get assigned somewhere in the maze of the init/probe code. I would feel more comfortable if we kept the information as as flag in struct console so that even the generic callbacks could use it. Anyway, it makes sense to create a sepate flag for this purpose, e.g. CON_FORCE or CON_FORCE_ENABLE. > return 0; > } > console_initcall(ma35d1serial_console_init); Best Regards, Petr