From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 1/2] lib/cmdline_kunit: add test case for memparse()
Date: Thu, 22 Jan 2026 13:46:44 +0200 [thread overview]
Message-ID: <aXIOJEqV_ctVRrok@smile.fi.intel.com> (raw)
In-Reply-To: <20260122111254.1111811-2-dmantipov@yandex.ru>
On Thu, Jan 22, 2026 at 02:12:53PM +0300, Dmitry Antipov wrote:
> Better late than never, now there is a long-awaited basic
> test for 'memparse()' which is provided by cmdline.c.
Thank you for this! Really appreciate!
See a couple of nit-picks below.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
assuming they will be amended.
...
> +static const struct cmdline_test_memparse_entry testdata[] = {
> + { "0", "", 0ULL },
> + { "1", "", 1ULL },
> + { "a", "a", 0ULL },
> + { "0xb", "", 11ULL },
> + { "0xz", "x", 0ULL },
> + { "1234", "", 1234ULL },
> + { "04567", "", 2423ULL },
> + { "0x9876", "", 39030LL },
> + { "05678", "8", 375ULL },
> + { "0xabcdefz", "z", 11259375ULL },
> + { "0cdba", "c", 0ULL },
> + { "4K", "", 4096ULL },
> + { "0x10k@0xaaaabbbb", "@", 16384ULL },
> + { "32M", "", 33554432ULL },
These can utilize constants from sizes.h.
> + { "067m:foo", ":", 57671680ULL },
> + { "2G;bar=baz", ";", 2147483648ULL },
Ditto.
> + { "07gz", "z", 7516192768ULL },
> + { "3T+data", "+", 3298534883328ULL },
> + { "04t,ro", ",", 4398046511104ULL },
Ditto. (However I don't remember the maximum available there.)
> + { "012p", "", 11258999068426240ULL },
> + { "7P,sync", ",", 7881299347898368ULL },
> + { "0x2e", "", 46ULL },
> + { "2E and more", " ", 2305843009213693952ULL },
> + { "18446744073709551615", "", 18446744073709551615ULL },
> + { "18446744073709551616", "", 0ULL }
Leave trailing comma as it's not a terminator.
Can we also have one with more than 20 decimal digits?
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-22 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 11:12 [PATCH 0/2] minor lib/cmdline enhancements Dmitry Antipov
2026-01-22 11:12 ` [PATCH 1/2] lib/cmdline_kunit: add test case for memparse() Dmitry Antipov
2026-01-22 11:46 ` Andy Shevchenko [this message]
2026-01-22 15:00 ` Dmitry Antipov
2026-01-22 15:25 ` Andy Shevchenko
2026-01-22 11:12 ` [PATCH 2/2] lib/cmdline: adjust a few comments to fix kernel-doc -Wreturn warnings Dmitry Antipov
2026-01-22 11:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXIOJEqV_ctVRrok@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=djwong@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox