Re: [PATCH v1 1/1] ACPI: processor: idle: Replace strlcat() with better alternative

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Mar 20, 2026 at 12:17:54PM -0700, Kees Cook wrote:
> On Mon, Mar 16, 2026 at 06:01:58PM +0100, Andy Shevchenko wrote:
> > strlcpy() and strlcat() are confusing APIs and the former one already gone
> > from the kernel. In preparation to kill strlcat() replace it with the better
> > alternative.
> 
> Yes please. There are a few places I looked at in the past that might
> benefit from being changed to seq_buf or similar (where snprintf doesn't
> cut it), but otherwise the removal of strlcat should be straight forward
> and would be well appreciated. :)

Thank you for confirming, this is basically the message to Josh to find
users and start converting them and kill strlcat() eventually. Josh, as
you see it will be well appreciated!

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Kees Cook <kees@kernel.org>

Thanks! There was a v2 which Rafael already accepted where scnprintf() is used
due to GCC complains about snprintf() potential string cuts.

-- 
With Best Regards,
Andy Shevchenko