From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A18725A2BB for ; Wed, 25 Jun 2025 21:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.89.44.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750887842; cv=none; b=uvc3vLQb71zq9BxHMB8cVM6keoXxP5AmiT6AyC6G/rROAlqES/V+Br5DC6npNBgI105SgaTXGW6w+HFUKy/uYH53SZjh+OMbSYyAhS0R8YuyNgDWr62cf6erndWEzW55J1YHYuaB+LzYQslCfRp9XN5HR9u0L/hihpS/qc+57OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750887842; c=relaxed/simple; bh=5lynVMriVClgMthsFZJ0Tvkpa1tGB9Lp6lL6aLGaCBE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RFDclVD5XbXe6pg/WzUh0oAZbjHtKt1725Yxa42eOssjCyacRmvyiaiS1QTDl0szwAl7kYOAkykorJ7LgenM4TaY362taNkUrgGDYUwekrVLHNYMVec6VunzGgrOn3g3xOaa9F65xpA7wX+v1wnfZvHObur6ShLpfvSe8VLBjaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=WXvUjmL4; arc=none smtp.client-ip=35.89.44.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="WXvUjmL4" Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id UT4wuh7ZvMETlUXuMux6Sl; Wed, 25 Jun 2025 21:43:54 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id UXuLuKrJ51vNyUXuLuQVsK; Wed, 25 Jun 2025 21:43:54 +0000 X-Authority-Analysis: v=2.4 cv=VMQWnMPX c=1 sm=1 tr=0 ts=685c6d9a a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=y7jUFFJD1EYPe7d4fIfORw==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=7T7KSl7uo7wA:10 a=QyXUC8HyAAAA:8 a=h90DJapn4poTkUJIt3kA:9 a=QEXdDO2ut3YA:10 a=xYX6OU9JNrHFPr8prv8u:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WSgqlLPFusC6Fal/vnl5EKpDH7EySq/W8ghCEckfU5w=; b=WXvUjmL4YQUvHcCnKTe5kb8SCL rnsv9zd6wvXpCP6BdUJEdEbS31FOYKxFzF5vK8xh1+91vJAqPlhKhBaWKsraEtwzk01P9PrbHxwcq I/v7ZOHYGKSTvVY/M84F+sJ4bP7RfEjL4yLqdGRy+lQeah6WgGWd1L7sQ9J3E43eBzflxqbqqvT7k tiAPJXW+zpRgDpS3hwJgcwJjIWx8UYfPrl/b+sEBSLpn7qDUpZNXng7jeq2w5mmOxnemOTgLyJv4x zMvUMqT8j0WOX59MfgQq4dAKM5geL3mQrqWmRTk+LecokoXvh1oy6OAU35KAWqAx570X5V4+YQCIm YB8ybK4A==; Received: from [177.238.16.137] (port=49324 helo=[192.168.0.27]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.1) (envelope-from ) id 1uUXuJ-00000000LhW-3HeQ; Wed, 25 Jun 2025 16:43:51 -0500 Message-ID: Date: Wed, 25 Jun 2025 15:43:41 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3][next] acpi: nfit: intel: avoid multiple -Wflex-array-member-not-at-end warnings To: dan.j.williams@intel.com, Kees Cook , "Gustavo A. R. Silva" Cc: Vishal Verma , Dave Jiang , Ira Weiny , "Rafael J. Wysocki" , Len Brown , nvdimm@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <202506250950.31C8A58E@keescook> <685c5d0062f2b_1608bd10051@dwillia2-xfh.jf.intel.com.notmuch> <685c653a6fe42_1608bd100d0@dwillia2-xfh.jf.intel.com.notmuch> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <685c653a6fe42_1608bd100d0@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 177.238.16.137 X-Source-L: No X-Exim-ID: 1uUXuJ-00000000LhW-3HeQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.27]) [177.238.16.137]:49324 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 1 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBz21cs3j63TVgrvWaMCOehfW3biycFzGkC25AWU/lyGGF7QKbagP2HTGHxLbqJxHHlBXG09/a0zxNvKQmisqGFwIAEPImlmy/xYaTPkDiGTpUvNRlXg /GNJL0k+82037mN/6+qHrMzmcCIKEm34QOdnn3FUke2uD+nMJ2aVDb+JUbjYEXYDdrNhePC2xfwsFCJuqgkul7wUVxG1t3yRNJVjzmlYiTSaNXrB4kNiSSHW On 25/06/25 15:08, dan.j.williams@intel.com wrote: > dan.j.williams@ wrote: >> Gustavo A. R. Silva wrote: >> [..] >>>> I think it would be a pretty small and direct replacement: >>>> >>>> TRAILING_OVERLAP(struct nd_cmd_pkg, pkg, nd_payload, >>>> struct nd_intel_get_security_state cmd; >>>> ) nd_cmd = { >>>> ... >>> >>> Yes, this works. Hopefully, maintainers will comment on this and let us >>> know what they prefer. :) >> >> Hey Gustavo, apologies for the latency here. I think TRAILING_OVERLAP() >> looks lovely for this if only because I can read that and have an idea >> what it means vs wondering what this _offset_to_fam is about and needing >> to read the comment. >> >> If you can get me that patch on top of the TRAILING_OVERLAP() branch I >> can test it out and ack it to let it do in through the KSPP tree. > > Just to move this along, I gave this conversion a try and all looks good > here. So feel free to fold this in and add: > > Acked-by: Dan Williams > Tested-by: Dan Williams > > ...and take it through the KSPP tree with the TRAILING_OVERLAP() merge. Thank you, Dan! :) -Gustavo