Re: [PATCH 06/22] dt-bindings: iio: dac: ad5686: rework on power supplies

Conor Dooley
2026-04-23T17:32:46Z

[-- Attachment #1: Type: text/plain, Size: 2223 bytes --]

On Wed, Apr 22, 2026 at 03:45:40PM +0100, Rodrigo Alencar via B4 Relay wrote:
> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
>
> Add supplies for VDD, VLOGIC and VREF input voltage pins. The vcc-supply
> property is deprecated. Certain devices require vref-supply to be

Why is it deprecated? Is the naming incorrect?

> available once an internal reference voltage is absent. Still, this patch
> does not add those as 'required' so that the ABI is not broken.
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> ---
> .../devicetree/bindings/iio/dac/adi,ad5686.yaml | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index 543ee181f7b3..3292d5190b70 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -40,8 +40,22 @@ properties:
> reg:
> maxItems: 1
>
> + vdd-supply:
> + description: Input power supply.
> +
> + vlogic-supply:
> + description:
> + Digital power supply. If not supplied, it is assumed to be the same as
> + vdd-supply. VLOGIC may be hardwired to VDD in some board designs or
> + internally connected in small packages.
> +
> + vref-supply:
> + description:
> + Reference voltage supply. If not supplied the internal reference is used.
> +
> vcc-supply:
> - description: If not supplied the internal reference is used.
> + deprecated: true
> + description: Use vref-supply instead.
>
> reset-gpios:
> description: Active-low RESET pin to reset the device.
> @@ -89,7 +103,9 @@ examples:
> dac@0 {
> reg = <0>;
> compatible = "adi,ad5310r";
> - vcc-supply = <&dac_vref0>;
> + vdd-supply = <&dac_vdd>;
> + vlogic-supply = <&dac_vlogic>;
> + vref-supply = <&dac_vref>;
> reset-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
> ldac-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> };
>
> --
> 2.43.0
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]