From: Vincent Mailhol <mailhol@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nicolas Schier <nicolas@fjasle.eu>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kbuild@vger.kernel.org, linux-sparse@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-btrfs@vger.kernel.org,
linux-hardening@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: [PATCH] overflow: Update is_non_negative() and is_negative() comment
Date: Fri, 2 Jan 2026 23:29:23 +0100 [thread overview]
Message-ID: <b6b35138-2c37-4b82-894e-59e897ec7d58@kernel.org> (raw)
In-Reply-To: <b549e430-5623-4c60-acb1-4b5e095ae870@kernel.org>
The is_non_negative() and is_negative() function-like macros initially
exist as a workaround to silence the -Wtype-limits warning. Now that
this warning is disabled, those two macros have lost their raison
d'être. Or so we thought.
In reality, smatch still produces a similar warning and so, it is
unfortunately still too early to undo this workaround.
Update the comment to point to smatch instead of GCC's -Wtype-limits.
Add a link to the thread in which this was discovered.
Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Link: https://lore.kernel.org/all/CANiq72=jRT+6+2PBgshsK-TpxPiRK70H-+3D6sYaN-fdfC83qw@mail.gmail.com/
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
include/linux/overflow.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/overflow.h b/include/linux/overflow.h
index 736f633b2d5f..d84194fc783b 100644
--- a/include/linux/overflow.h
+++ b/include/linux/overflow.h
@@ -37,8 +37,8 @@
#define type_min(t) __type_min(typeof(t))
/*
- * Avoids triggering -Wtype-limits compilation warning,
- * while using unsigned data types to check a < 0.
+ * Avoids triggering "unsigned 'a' is never less than zero" smatch warning,
+ * Link: https://lore.kernel.org/all/acdd84b2-e893-419c-8a46-da55d695dda2@kernel.org
*/
#define is_non_negative(a) ((a) > 0 || (a) == 0)
#define is_negative(a) (!(is_non_negative(a)))
--
2.52.0
next prev parent reply other threads:[~2026-01-02 22:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 11:02 [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 1/3] " Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 2/3] kbuild: cleanup local -Wno-type-limits exceptions Vincent Mailhol
2025-12-20 12:53 ` Nicolas Schier
2025-12-20 11:02 ` [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative() Vincent Mailhol
2025-12-20 12:52 ` Nicolas Schier
2025-12-22 10:03 ` kernel test robot
2025-12-22 18:39 ` Vincent Mailhol
2025-12-22 19:55 ` kernel test robot
2025-12-25 6:04 ` kernel test robot
2025-12-27 8:49 ` kernel test robot
2025-12-28 1:41 ` kernel test robot
2026-01-01 15:10 ` Vincent Mailhol
2026-01-01 19:39 ` Nicolas Schier
2026-01-02 11:04 ` Miguel Ojeda
2026-01-02 22:26 ` Vincent Mailhol
2026-01-02 22:29 ` Vincent Mailhol [this message]
2026-01-03 10:02 ` [PATCH] overflow: Update is_non_negative() and is_negative() comment Dan Carpenter
2026-01-03 11:10 ` Vincent Mailhol
2026-01-03 16:56 ` Dan Carpenter
2026-01-03 19:40 ` Vincent Mailhol
2026-01-05 7:26 ` Dan Carpenter
2026-01-05 23:56 ` [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b35138-2c37-4b82-894e-59e897ec7d58@kernel.org \
--to=mailhol@kernel.org \
--cc=airlied@gmail.com \
--cc=clm@fb.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas@fjasle.eu \
--cc=nsc@kernel.org \
--cc=simona@ffwll.ch \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox