From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8D23EA76 for ; Tue, 24 Dec 2024 22:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.89.44.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735080147; cv=none; b=StPBVfCjb6B5lao3+RGpyQJLL0PL58IPzEaQdOwVuP41+eUIeDRJ0yqcNeZ3BiGAmYc/nwuK7Vpy6ab//UOXo25u3bJSSpWKxMQZ7huiv+L2CibTsQ+uVIPxANSGZnV/oOLABHsvv981Knf5xZgvz25DxzCRglXrbdq9p4Q6/FI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735080147; c=relaxed/simple; bh=K8ig6pkFQ3cnVKESEWnVAmSC4k6wZ/nk6iODVwwKRYM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q8y7yQFcj7jBWpOj/QFCESgw4k7xo1y4Rbfa3usbcGMJerc53zWl5KX7wprRTaqGJCYkM8s5T3QpmSSTUu3PrMVBRyK12dUsx0XBH3DKRjKolFn2aLLySQhMr4ZPOSnDAQwZFnlIAPdE2mnAHdIzAQPMEzgtSHTyF4YlMnCn3BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=wE8KaOf4; arc=none smtp.client-ip=35.89.44.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="wE8KaOf4" Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id Q4W4t9lFMumtXQDbctnsTT; Tue, 24 Dec 2024 22:42:24 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id QDbbtZliyWvXpQDbbth8wJ; Tue, 24 Dec 2024 22:42:23 +0000 X-Authority-Analysis: v=2.4 cv=LtdZyWdc c=1 sm=1 tr=0 ts=676b38cf a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=GtNDhlRIH4u8wNL3EA3KcA==:17 a=IkcTkHD0fZMA:10 a=RZcAm9yDv7YA:10 a=7T7KSl7uo7wA:10 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=oOqFFZS7AAAA:8 a=8gwe23exSknoF3-mrEwA:9 a=QEXdDO2ut3YA:10 a=9cHFzqQdt-sA:10 a=PUnBvhIW4WwA:10 a=cEm2zIq8e6p76x6pLsf5:22 a=Xt_RvD8W3m28Mn_h3AK8:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=na2/0I+XXDoadhe2QTikJdF+DpeX36K5jAfWFUya8rQ=; b=wE8KaOf4zXbKZ7yWtXtAWc1EyY 8TYTKZjfaFU5owzlTFbsimAUHnLnjHKNEQ9THMKMdjskKQG3arjgBiRMuuxO95gjnz7UIVxoS2MPa FvmtEWi9J8fDQZJrgwbBaaU/mYwbmsGuhGlSDD5DQ9Mi0WS03bG52w2r3CCA72yXM3MwLvv91xs6/ jZLrRrSr/5FWinbHIz/nOHwn2fQb2ejpaWeBmFuXw+wDCYf7bMc04PLZV3gUWSr1n2Z0DUvNLI50F 2X2/v6+x5B8nb6veE4kY9Ma1k5Ev+Vvmlx2SsDcxf9PI56nEPHK+v1X/diMgLB78gqJRVIEi7ZqXo w4Suying==; Received: from [177.238.21.80] (port=33898 helo=[192.168.0.21]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1tQDba-002hf6-0r; Tue, 24 Dec 2024 16:42:22 -0600 Message-ID: Date: Tue, 24 Dec 2024 16:42:07 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dm: change kzalloc to kcalloc To: Ethan Carter Edwards , "agk@redhat.com" Cc: "snitzer@kernel.org" , "dm-devel@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kernel-hardening@lists.openwall.com" , "linux-hardening@vger.kernel.org" , "mpatocka@redhat.com" References: Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 177.238.21.80 X-Source-L: No X-Exim-ID: 1tQDba-002hf6-0r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.21]) [177.238.21.80]:33898 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDrizBiuw+bnCb32ODQ7xA0UpNAeHS6Ff64xNjrZ8Om4H8UgVdjaRut1E9phGPBz5WclQ7zs4GRJKY7zHiZLk2K10B3AhNXXVbzxMjr4+PYwAbDLIaeW lti1Ca1vogsJb7Mac9URa8Nk62jSVhIE+HlQ+R4TdCCszNrizUgTCh92jGv+CmEuppldouJaQCI+U3g1tGj4X2N2yVHsmrvrpbHfcDH/qcQ23RNhMwglfSvR On 24/12/24 16:13, Ethan Carter Edwards wrote: > Use 2-factor multiplication argument form kcalloc() instead > of instead of the deprecated kzalloc() [1]. Thanks for the patch - Just note that kzalloc() is by no means deprecated. > > [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > Link: https://github.com/KSPP/linux/issues/162 > > Signed-off-by: Ethan Carter Edwards Reviewed-by: Gustavo A. R. Silva -Gustavo > --- > drivers/md/dm-ps-io-affinity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-ps-io-affinity.c b/drivers/md/dm-ps-io-affinity.c > index 461ee6b2044d..716807e511ee 100644 > --- a/drivers/md/dm-ps-io-affinity.c > +++ b/drivers/md/dm-ps-io-affinity.c > @@ -116,7 +116,7 @@ static int ioa_create(struct path_selector *ps, unsigned int argc, char **argv) > if (!s) > return -ENOMEM; > > - s->path_map = kzalloc(nr_cpu_ids * sizeof(struct path_info *), > + s->path_map = kcalloc(nr_cpu_ids, sizeof(struct path_info *), > GFP_KERNEL); > if (!s->path_map) > goto free_selector;