Linux Hardening
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Lee Jones" <lee@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
	"Kees Cook" <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	willmcvicker@google.com, jyescas@google.com,
	shin.son@samsung.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH 3/8] dt-bindings: mfd: Add Google GS101 TMU Syscon
Date: Fri, 16 Jan 2026 11:18:22 +0200	[thread overview]
Message-ID: <d3dedf5e-ada3-4d33-b1a5-7556ba80ffb1@linaro.org> (raw)
In-Reply-To: <0176a63a-6b04-4e30-b718-847133882050@kernel.org>



On 1/16/26 11:14 AM, Krzysztof Kozlowski wrote:
> On 16/01/2026 09:50, Tudor Ambarus wrote:
>>
>> Because of the hybrid approach I'm arguing the ACPM child node does not
>> fully describe the hardware, and it's just a firmware abstraction.
>> So option 2/ would be to have just the TMU IP block described with a
>> phandle to the ACPM IPC:
>>
>> soc: soc@0 {
>>     tmu@100a0000 {
>>         compatible = "google,gs101-tmu-top";
>>         reg = <0x100a0000 0x800>;
>>         clocks = <&cmu_misc CLK_GOUT_MISC_TMU_TOP_PCLK>;
>>         interrupts = <GIC_SPI 769 IRQ_TYPE_LEVEL_HIGH 0>;
>>         
>>         /* The "Firmware Phandle" approach */
>>         samsung,acpm-ipc = <&acpm_ipc>;
>>         
>>         #thermal-sensor-cells = <1>;
> 
> Yes, this one, I think it's the best representation.

I was leaning towards this as well. Thank you! I'll start reworking the
patches.

Cheers,
ta


  reply	other threads:[~2026-01-16  9:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 14:16 [PATCH 0/8] thermal: samsung: Add support for Google GS101 TMU Tudor Ambarus
2026-01-14 14:16 ` [PATCH 1/8] dt-bindings: thermal: Add " Tudor Ambarus
2026-01-15 13:32   ` Krzysztof Kozlowski
2026-01-19 12:45     ` Tudor Ambarus
2026-01-19 12:57       ` Krzysztof Kozlowski
2026-01-14 14:16 ` [PATCH 2/8] dt-bindings: firmware: google,gs101-acpm-ipc: Add TMU child node Tudor Ambarus
2026-01-14 14:16 ` [PATCH 3/8] dt-bindings: mfd: Add Google GS101 TMU Syscon Tudor Ambarus
2026-01-15 13:36   ` Krzysztof Kozlowski
2026-01-15 14:53     ` Tudor Ambarus
2026-01-15 15:34       ` Krzysztof Kozlowski
2026-01-15 16:10         ` Tudor Ambarus
2026-01-16  8:50           ` Tudor Ambarus
2026-01-16  9:14             ` Krzysztof Kozlowski
2026-01-16  9:18               ` Tudor Ambarus [this message]
2026-01-14 14:16 ` [PATCH 4/8] firmware: samsung: acpm: Add TMU protocol support Tudor Ambarus
2026-01-14 14:16 ` [PATCH 5/8] thermal: samsung: Add support for GS101 TMU Tudor Ambarus
2026-01-14 14:16 ` [PATCH 6/8] MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver Tudor Ambarus
2026-01-14 14:16 ` [PATCH 7/8] arm64: dts: exynos: gs101: Add thermal management unit Tudor Ambarus
2026-01-14 14:16 ` [PATCH 8/8] arm64: defconfig: enable Exynos ACPM thermal support Tudor Ambarus
2026-01-15 13:21   ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3dedf5e-ada3-4d33-b1a5-7556ba80ffb1@linaro.org \
    --to=tudor.ambarus@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=bzolnier@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=jyescas@google.com \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=peter.griffin@linaro.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=shin.son@samsung.com \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox