From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D920A5695 for ; Fri, 5 Apr 2024 00:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712278587; cv=none; b=nO0NPD0vBmh/sLG2rSueRtptTpk5RS2LeYj8UDUzLAyzAhSMnRYh02Iuf+H3ZgNQuixn4h9DcvlqqgrPwXmcYxG3bjiC1zi03BfRM/s9k7XATUR12O+aAChFDRXtd0oa8WOiatYyC4Ii6/c3XVtp8IzXNNFZ4nuKVlsYw2R26G8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712278587; c=relaxed/simple; bh=d2QTWIhRLklitVHu2Oh2ADoKsDCo73AL3mTjsvV9E/8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HEdSrowoVT3vf6NzgR4l6K1xi5IBW3JGrax8Ts4Yw4gQq+2/ROzzK1TnaExxGBPB8FuPLMg68CwD6JNAIkrspdBHuRSjbRlQ+96WaFEBnf7SukmwnIffCzNU+8/gXjlkvY6AWFksjg/gr8GK1vx+VPL6oLttjqD+fivLofuMMkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=cdHf16/q; arc=none smtp.client-ip=44.202.169.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="cdHf16/q" Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id rsitrn51muh6ssXsUrLwek; Fri, 05 Apr 2024 00:56:23 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id sXsTruB0ouv6XsXsUrJReN; Fri, 05 Apr 2024 00:56:22 +0000 X-Authority-Analysis: v=2.4 cv=YbZ25BRf c=1 sm=1 tr=0 ts=660f4c36 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=4VnFru8p6tJF5H7f7NqpSA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=wYkD_t78qR0A:10 a=LXjggWPQbdiaP0PAf5wA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dMo9+qC7khZWpqLef3na1COCT0ZhcpCRolgSVK3QXHY=; b=cdHf16/qhI8JTbGUioMN8W8jaW TvWWbeDUNvI3jTbCp3P2ae2UdUHz78etxP0SVcLI+RTpVsBZGEceCq2O4WbiTBJWK9LjcD0HBTy5c NCCtcQK38GdT5ArT4AYsL/44ilwrMrw9O8qFqDXWgxMg+Romwx75T9MTOgDO15EjlyJuXEHU24deO +R09I1L1c5hehvYvogtOY82yP5XAemE06FC8fLoO5btjE6L1Z/BeVrGcJSPQAzrqx41HnY5iH0k/k 40K3GeOl1mtqvcSNChRFr0UNtvLPP9bgbISuXJaVdoLy0c7ktrWr7SWBYV0FEEo941Av+pfxFThuW ImhVp4PA==; Received: from [187.184.159.122] (port=19621 helo=[192.168.0.27]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rsXsR-004J8b-2u; Thu, 04 Apr 2024 19:56:20 -0500 Message-ID: Date: Thu, 4 Apr 2024 18:56:15 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings To: Mimi Zohar , "Gustavo A. R. Silva" , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <27d36ec8e0539c5d6bc760de7305299a2142f9f1.camel@linux.ibm.com> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.184.159.122 X-Source-L: No X-Exim-ID: 1rsXsR-004J8b-2u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.27]) [187.184.159.122]:19621 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 1 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIBqR2RUlxMfH1D8VlB6PyOFtllE4QbgQRYVkr7Z1QD7pSzUmvRqgKLnlVr155jE4tuILJ1UVA4tabTTvYeqgKmlQYMEix4GYL/VIr2zEnxFqIF/UmL/ WdFOKJIFcCFV1pioUoyG9cKDKUKfN+yVCHVRqk1xuWBWAFVUX3gCM+6QKM+buzBUagy1n55LlO7cKS7BnUGtSGgcCsZkofFiPdowgc4Q1LBiruqpfZ9AK0I8 > "checkpatch.pl --strict" complains "CHECK: Alignment should match open > parenthesis". I'll queue the patch, but how about teaching checkpatch.pl to > ignore __struct_group()? I think this would do it: diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9c4c4a61bc83..e229b97f17f6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3958,7 +3958,7 @@ sub process { my $rest = $2; my $pos = pos_last_openparen($rest); - if ($pos >= 0) { + if ($pos >= 0 && $rest !~ /(__)?struct_group(_(tagged|attr))?(\()/) { $line =~ /^(\+| )([ \t]*)/; my $newindent = $2; I'll send a proper patch. Thanks for the suggestion, Mimi. -- Gustavo