From: Jens Axboe <axboe@kernel.dk>
To: Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Justin Sanders <justin@coraid.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, Xu Panda <xu.panda@zte.com.cn>,
Yang Yang <yang.yang29@zte.com>
Subject: Re: [PATCH] aoe: refactor deprecated strncpy
Date: Mon, 18 Sep 2023 08:00:45 -0600 [thread overview]
Message-ID: <e6433ada-16db-4d16-801b-9a3fd5460467@kernel.dk> (raw)
In-Reply-To: <CAFhGd8pwtUSJBzepe=GBeyKuhD6ND6aWjeeT477Sdb4YTYDL_Q@mail.gmail.com>
On 9/18/23 1:03 AM, Justin Stitt wrote:
>> Change looks fine to me too, but for the love of $deity, please use
>> a proper subject line for these kinds of patches. It's not refactoring
>> anything.
>>
>
> Fair.
>
> Perhaps "xyz: replace strncpy with strscpy"?
That's a lot more descriptive, as a) it's actually accurate, and b) this
is what the patch does. You just sent another one with this refactor
wording which makes zero sense, please resend this and others targeted
at block with a proper description.
--
Jens Axboe
prev parent reply other threads:[~2023-09-18 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 21:09 [PATCH] aoe: refactor deprecated strncpy Justin Stitt
2023-09-15 3:21 ` Kees Cook
2023-09-15 13:36 ` Jens Axboe
2023-09-18 7:03 ` Justin Stitt
2023-09-18 14:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6433ada-16db-4d16-801b-9a3fd5460467@kernel.dk \
--to=axboe@kernel.dk \
--cc=justin@coraid.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).