Linux Hardening
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning
Date: Thu, 3 Oct 2024 21:09:02 +0200	[thread overview]
Message-ID: <e9a05386-54d8-4a18-8b16-4e871de094a4@kernel.org> (raw)
In-Reply-To: <45560975-7215-4205-8d3b-a01009c9b4f5@embeddedor.com>

On 10/3/24 8:44 PM, Gustavo A. R. Silva wrote:
> 
> 
> On 03/10/24 12:36, Danilo Krummrich wrote:
>> On 9/13/24 12:23 PM, Danilo Krummrich wrote:
>>> Hi,
>>>
>>> On 9/13/24 10:09 AM, Gustavo A. R. Silva wrote:
>>>> Hi all,
>>>>
>>>> Friendly ping: who can take this, please? 🙂
>>>
>>> Usually, that's me. But I thought you might want to send a v2 based on Kees'
>>> comments?
>>
>> Do you plan to follow up on this? I'd prefer if we could get rid of the open-
>> coded "17". So, maybe just go with the define until we have something like
>> STACK_FLEX_COUNT()?
> 
> Do you mean the following define...?>
> nv50_hdmi_enable(...)
> {
> ...
> #define data_len    17
>      DEFINE_RAW_FLEX(struct nvif_outp_infoframe_v0, args, data, data_len);
> ...rest of function...
> #undef data_len
> }

Yes, it's not great, but I think it's better than having the length in two
places.

> 
> Thanks
> -- 
> Gustavo
> 


  reply	other threads:[~2024-10-03 19:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 20:16 [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2024-08-22 17:27 ` Kees Cook
2024-08-27 19:09   ` Gustavo A. R. Silva
2024-09-13  8:09 ` Gustavo A. R. Silva
2024-09-13 10:23   ` Danilo Krummrich
2024-10-03 18:36     ` Danilo Krummrich
2024-10-03 18:44       ` Gustavo A. R. Silva
2024-10-03 19:09         ` Danilo Krummrich [this message]
2024-10-03 19:13           ` Gustavo A. R. Silva
2024-10-05 16:04         ` Kees Cook
2024-10-14 22:43           ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a05386-54d8-4a18-8b16-4e871de094a4@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=kherbst@redhat.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox