From: Jared Finder <jared@finder.org>
To: linux-hardening@vger.kernel.org
Subject: GPM & Emacs broken in Linux 6.7 -- ok to relax check?
Date: Fri, 29 Nov 2024 11:33:31 -0800 [thread overview]
Message-ID: <ee3ec63269b43b34e1c90dd8c9743bf8@finder.org> (raw)
The change to restrict access to TIOCLINUX that was added in Linux 6.7
breaks Emacs rendering of the mouse pointer. This change was previous
discussed in
https://lwn.net/ml/kernel-hardening/20230402160815.74760f87.hanno@hboeck.de/.
An associated Emacs bug report, bug #74220, is discussed at
https://lists.gnu.org/archive/html/bug-gnu-emacs/2024-11/msg00275.html.
I wanted to ask if it made sense for the restriction to not apply to the
following three selection modes for TIOCL_SETSEL:
TIOCL_SELPOINTER 3 /* show the pointer */
TIOCL_SELCLEAR 4 /* clear visibility of selection */
TIOCL_SELMOUSEREPORT 16 /* report beginning of selection */
On a glance over the selection code, none of these interact with
vc_sel.buffer and therefore are unrelated to the exploit linked in the
original report. Only SELPOINTER is necessary to be available to fix
Emacs bug #74220. I imagine such a change would involve moving the
capability check from tioclinux(), case TIOCL_SETSEL to inside
vc_do_selection().
Note: This is my first time emailing a Linux kernel mailing list, so
please let me know if there's any additional conventions I should be
following here.
Thank you for your time.
-- MJF
next reply other threads:[~2024-11-29 19:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 19:33 Jared Finder [this message]
2024-11-29 19:50 ` GPM & Emacs broken in Linux 6.7 -- ok to relax check? Jann Horn
2024-12-03 13:53 ` Günther Noack
2024-12-03 14:07 ` Günther Noack
2024-12-14 5:13 ` Jared Finder
2024-12-14 7:47 ` Greg Kroah-Hartman
2024-12-16 15:07 ` [PATCH] tty: Permit some TIOCL_SETSEL modes without CAP_SYS_ADMIN Günther Noack
2024-12-16 15:14 ` Greg Kroah-Hartman
2024-12-16 15:17 ` Greg Kroah-Hartman
2024-12-16 15:42 ` Günther Noack
2024-12-21 11:06 ` Günther Noack
2024-12-21 11:10 ` [PATCH v2] " Günther Noack
2024-12-22 8:37 ` Greg Kroah-Hartman
2025-01-10 14:21 ` Günther Noack
2025-01-10 16:50 ` Kees Cook
2025-02-08 15:18 ` Jared Finder
2025-02-08 15:28 ` Greg KH
2025-02-08 16:03 ` Jared Finder
2025-02-09 6:49 ` Greg KH
2025-02-21 0:10 ` Günther Noack
2025-02-22 21:07 ` Jared Finder
2025-01-12 13:14 ` Greg Kroah-Hartman
2024-12-17 9:09 ` [PATCH] " Günther Noack
2024-12-17 8:47 ` GPM & Emacs broken in Linux 6.7 -- ok to relax check? Hanno Böck
2024-12-17 8:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3ec63269b43b34e1c90dd8c9743bf8@finder.org \
--to=jared@finder.org \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox