From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93E8138BDB6 for ; Tue, 13 Jan 2026 09:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296105; cv=none; b=I7VQSgEKGmuGQSecC3lGSFj7nZ+hYzPgVGg7/FtNqZ/3EjnNqpXnUi283BOVgug9SXXyHHdjWrXh9WX8eBgQ7wBCf59F+STlxDYOia9tQZqm6rXlfPTObJA2hQ9eO6Ai8qBiIer7Rw94xWLvOHKw7zHLUaRCOOqKlZKhcKAaBik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296105; c=relaxed/simple; bh=IL9GEg3VWIuo4o/aOy+T2nt90+e7EZnrfEvtZfYuLeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IiuO9rCiCyAgO3mxIw9rUZv/pOAJbDNpRkqvGf528W1wXSiE15LSgnqcmkgs4Ni87//+swtDWH5HE//iOuMqeou+zFEz40stKlgBtU30SmG/C8Zmyi2lMslVjZrXojwEv2h1nFPqPsixK6MpT5/OULNlcKAaTUCLiQ8jm8N7tbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fIkMc2pZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VdI145sV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fIkMc2pZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VdI145sV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D1tcST2751682 for ; Tue, 13 Jan 2026 09:21:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IL9GEg3VWIuo4o/aOy+T2nt90+e7EZnrfEvtZfYuLeY=; b=fIkMc2pZi2aLFVhz zM97mTrnfYH9GSLqd1wLKELqs/tsc6c/GoxbC9JDN+rWou482nByOAKiP6f/QtxK OkG0jX5uJHPNYxcNS9MrPWN0UlAE/Dr5zEEoeUietUdOHRRjfEF7WXTLsItAeZgI qH7ujIauF4FAMUXunhdeDRZfB0viZkU+FR6OIWHQ1nEDp9Gv4aBggwGd6h9DEXUw 47j/DwSA5r3/5Ps/A2D4wUihJO9oPy4luGcicmIC0ma7DMfQR/ROgMy4oHNn7Aqb hdBt3C6TcRomQf4LE8XUZGetMIazwbo5SKgx4TS8fBJ4X+Apmv/9wgx1t0c1r7Ts SLmoOw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnctjs615-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 09:21:33 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b196719e0fso245016185a.2 for ; Tue, 13 Jan 2026 01:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768296093; x=1768900893; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IL9GEg3VWIuo4o/aOy+T2nt90+e7EZnrfEvtZfYuLeY=; b=VdI145sV+49f0hfUuHwmuQJLJ3063pq+kr8XQQ5efyF0LEu7NshuM5I8FtP9B/wsJ9 gaF1i3RVRmELN8nimcryF5tuutZY5p/X8cjqeeA25I2noKhTa6sjd2G53UYosWYIR0z8 JdJ+NbCYCUFVdsmg33E/nK8f4QkAwsoAGds/0wi34dNA4PtORKDwSwC9J//eeuPbuGpo AbwrPr8dsfreBC8Cf4WgWmGCaQJv0Vys4oK01vrZOWYqCjaFSHHRYmuqZdqJD5/M3akZ YnLEAEtl9D/RAj5n7/YCna/plQXyzFgMFd7G6oLQ4N9462O+Juv4+S0VJ+svB1GU/9iu x25A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768296093; x=1768900893; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IL9GEg3VWIuo4o/aOy+T2nt90+e7EZnrfEvtZfYuLeY=; b=BQR0H9DT7wgtRvXOdI/8lX43qhlCmtexe2R1E9ePNs+jlVKcXa0SHCmhyPWUBl5qYc U6SZoqhBrVbWLqzPvVy55wlM+bkv21XuKNhdw2xZAskM0BncF7e0jCHbg0pKEN+UQ6rG 1sHvfkO9tm5CI9LshQzwB332oP4O82gt73NkkFIwz4i16uk7osWiVCGA/tixpvfcBA7y ghn+5wBlDR0vctgVKyzpO9pMB2bDuwitATqWL9fwh5dw2MDQey6aqKmC4CwTpfE6IBqE zo7VeUKHNBgiYbNnTHgtzhS2SU5s2v/a9sLdIZsUq9AI4DqtotkLRzXJd5NRw9zBy1vH 4dcw== X-Forwarded-Encrypted: i=1; AJvYcCWAQUOkhka/oBhw8CP31v7/J5kIp0BTytdrAaY64G2YBuJ6YQRYVTdtQ3f85zmmT2V+KN4HbEtJyTCWZFJPaIw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8gCI7vKZfHE2Mf2TBYojyWV5AA503zJgD3Rjn/H/fjwEaH43H liU8OgRVocRbEbvM76aMmrEm4Q7cma5u/ecbJdPiRSvqlWQZoX1F1oNQyyt+f8DX8UJGSfL1HBo uE9jiplGWxssiMCTbFuFXNP00Bn2YP6QiTGSMYYqXLV2cVS2ps7BQs0agy5TiRfSK0CtS4D0= X-Gm-Gg: AY/fxX7X0llcF+ETjCB/Xmy5cREYpJB78fJsPxSzKqr9PQpvV6Mrvb+CWVw6UtCAe63 cCqEHmfd0eEDNvkDfKQL8kL3YcqWwIgUqAaxpMhUeb5J3SCKmosncJKcwejQU0XSYe5GlQIA9m3 7USYxWSr9RfmbSSHkNlL4OG3XM00USrsLPwPskMxLzPtBDVFsTjMo5tb16megOVA72FMvF9D2Io BBmf0yCG/Don9Yaix2mROUkkRLbqtAj91ph44BUMxXVInWCfo4LqavV0tuYJ8Zk5luYOE4j0Tlm YM63gvzQXG835CIQOaVjIcOaTtZanhxu5+L8s5jLyzeT3+cxdbwmEF+eXLZVSYeQZZsPCRIQ3W8 uHdNXiXfDV6XEdfZoI+NsEEvezRswiycoV1jfcL3SBzkJIBQZzHDLInobGrd7gtqFqZk= X-Received: by 2002:a05:620a:450d:b0:8c0:c999:df5a with SMTP id af79cd13be357-8c3893e473amr1945995685a.6.1768296092389; Tue, 13 Jan 2026 01:21:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsEcVJwKbgDHZjjh3kzPYbpyoPTpRoSAaXHNkk+gRf29/rnkJzQvTtxnhVExV4xg1iTKSzhQ== X-Received: by 2002:a05:620a:450d:b0:8c0:c999:df5a with SMTP id af79cd13be357-8c3893e473amr1945993485a.6.1768296091863; Tue, 13 Jan 2026 01:21:31 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8717a10ae1sm568069966b.32.2026.01.13.01.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 01:21:31 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 10:21:28 +0100 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges To: barnabas.czeman@mainlining.org Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Gabriel Gonzales , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Biswapriyo Nath , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20260112-xiaomi-willow-v1-0-8e4476897638@mainlining.org> <20260112-xiaomi-willow-v1-2-8e4476897638@mainlining.org> <233f73de-b247-4b22-a079-5bd3f5ece5cd@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA3OCBTYWx0ZWRfX24oXgFspE8mO eO1qn+oXL0gnc0NWz7AYPdJ2cjsaO+l7UdM5wkFjXRqT5tbfkyj5BulWWDAPQXNMI/Y1LdUR5kJ ZZFPs9nK4QDX3wP4K1o0+kJUyFiY1twxe4+UPm24PD0cvYva8euMize6DyFjgGMAdYS9ulQCOW1 iw8sR/SjmWaItTlJ27sLoFDe6n8xlDqfxCuJgXHvADnr4Bvk6MKvPqpZVUtXcFoNHbKBl3AQrwl ebKeNYepm2SVPTbbDVzi9pCAY2Hch8fRRSqcloDl9BSGFpMcMzymJrq96FSE4NBr5VbGpD9Rxc/ iZFrMk0wuRhtIr2QiINOLKnQz0ZtPKKysTOS5WXBuKppNpH6lj69zt/oHT6LNW1+AGAYVk3uDJp eOSISGtzLQ6GKRNQh/Y/pvsuunkmO7lz/V+gNyy9TK9KXAvgWgr99t8/gL/uLgKUHRop9dAo8jA BqA1Gg6jzYFgvfuDP4g== X-Authority-Analysis: v=2.4 cv=Ls2fC3dc c=1 sm=1 tr=0 ts=69660e9d cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OuZLqq7tAAAA:8 a=QM4QLvQof7z9zqEO4a4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-ORIG-GUID: GombYqXtzLgAnMrTBbNg44vOe-WmeRef X-Proofpoint-GUID: GombYqXtzLgAnMrTBbNg44vOe-WmeRef X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130078 On 1/13/26 10:14 AM, barnabas.czeman@mainlining.org wrote: > On 2026-01-13 09:53, Konrad Dybcio wrote: >> On 1/12/26 9:13 PM, Barnabás Czémán wrote: >>> The device was crashing on high memory load because the reserved memory >>> ranges was wrongly defined. Correct the ranges for avoid the crashes. >>> Change the ramoops memory range to match with the values from the recovery >>> to be able to get the results from the device. >>> >>> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo") >>> Signed-off-by: Barnabás Czémán >>> --- >>>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 44 ++++++++++++++++------- >>>  1 file changed, 32 insertions(+), 12 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>> index bf03226a6f85..4c548cb5f253 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts >>> @@ -13,6 +13,12 @@ >>>  #include "sm6125.dtsi" >>>  #include "pm6125.dtsi" >>> >>> +/delete-node/ &adsp_pil_mem; >>> +/delete-node/ &cont_splash_mem; >>> +/delete-node/ &gpu_mem; >>> +/delete-node/ &ipa_fw_mem; >>> +/delete-node/ &ipa_gsi_mem; >>> + >>>  / { >>>      model = "Xiaomi Redmi Note 8"; >>>      compatible = "xiaomi,ginkgo", "qcom,sm6125"; >>> @@ -36,28 +42,42 @@ framebuffer0: framebuffer@5c000000 { >>>      }; >>> >>>      reserved-memory { >>> -        debug_mem: debug@ffb00000 { >>> -            reg = <0x0 0xffb00000 0x0 0xc0000>; >>> +        adsp_pil_mem: adsp_pil_mem@55300000 { >>> +            reg = <0x0 0x55300000 0x0 0x2200000>; >>>              no-map; >>>          }; >>> >>> -        last_log_mem: lastlog@ffbc0000 { >>> -            reg = <0x0 0xffbc0000 0x0 0x80000>; >>> +        ipa_fw_mem: ipa_fw_mem@57500000 { >>> +            reg = <0x0 0x57500000 0x0 0x10000>; >>>              no-map; >>>          }; >>> >>> -        pstore_mem: ramoops@ffc00000 { >>> -            compatible = "ramoops"; >>> -            reg = <0x0 0xffc40000 0x0 0xc0000>; >>> -            record-size = <0x1000>; >>> -            console-size = <0x40000>; >>> -            pmsg-size = <0x20000>; >>> +        ipa_gsi_mem: ipa_gsi_mem@57510000 { >>> +            reg = <0x0 0x57510000 0x0 0x5000>; >>> +            no-map; >>>          }; >>> >>> -        cmdline_mem: memory@ffd00000 { >>> -            reg = <0x0 0xffd40000 0x0 0x1000>; >>> +        gpu_mem: gpu_mem@57515000 { >>> +            reg = <0x0 0x57515000 0x0 0x2000>; >>>              no-map; >>>          }; >>> + >>> +        framebuffer@5c000000 { >>> +            reg = <0x0 0x5c000000 0x0 (2340 * 1080 * 4)>; >>> +            no-map; >>> +        }; >>> + >>> +        /* >>> +         * Matching with recovery values >>> +         * to be able to get the results. >>> +         */ >> >> /* This is an unnecessarily >>  * squashed comment that could >>  * easily go into a single line >>  */ >> >> >>> +        ramoops@61600000 { >>> +            compatible = "ramoops"; >>> +            reg = <0x0 0x61600000 0x0 0x400000>; >>> +            record-size = <0x80000>; >>> +            pmsg-size = <0x200000>; >>> +            console-size = <0x100000>; >> >> Does your recovery image not specify ecc-size? > No. >> >> In my past experience, that led to much better results wrt the data >> being actually readable.. you might want to rebuild your recovery (or >> at least the dt and repack the boot.img) for that > I would not because i have got good results with this settings and > users could use already built recoveries to get the result. Ok, no worries then Konrad