From: Gal Pressman <gal@nvidia.com>
To: Ilya Maximets <i.maximets@ovn.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>
Cc: dev@openvswitch.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Jamal Hadi Salim <jhs@mojatatu.com>, Kees Cook <kees@kernel.org>,
David Ahern <dsahern@kernel.org>, Yotam Gigi <yotam.gi@gmail.com>,
Tariq Toukan <tariqt@nvidia.com>,
linux-hardening@vger.kernel.org, Simon Horman <horms@kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [ovs-dev] [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info
Date: Tue, 11 Feb 2025 17:38:31 +0200 [thread overview]
Message-ID: <f12c1f1e-3ae8-4cd8-b727-61c35b8ed9ce@nvidia.com> (raw)
In-Reply-To: <acf28b0e-5d34-46e0-823f-8028e2fb8356@ovn.org>
On 09/02/2025 22:16, Ilya Maximets wrote:
> Ideally we would have a proper union with all the potential option types
> instead of this hacky construct. But if that's not the the way to go, then
> 8 bytes may indeed be the way, as it is the maximum guaranteed alignment
> for allocations and the current alignment of the structure.
>
> But I'll leave this for others to weigh in.
Thank you Ilya.
Unless anyone has a better idea, I'm going to add an explicit alignment
to the options field, that would keep the struct layout as it was before
this patch.
next prev parent reply other threads:[~2025-02-11 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 10:18 [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info Gal Pressman
2025-02-09 16:21 ` [ovs-dev] " Ilya Maximets
2025-02-09 19:37 ` Gal Pressman
2025-02-09 20:16 ` Ilya Maximets
2025-02-11 15:38 ` Gal Pressman [this message]
2025-02-11 17:49 ` Kees Cook
2025-02-11 18:59 ` Gal Pressman
2025-02-12 0:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12c1f1e-3ae8-4cd8-b727-61c35b8ed9ce@nvidia.com \
--to=gal@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox