Linux Hardening
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Justin Stitt <justinstitt@google.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment
Date: Thu, 10 Aug 2023 15:51:30 -0600	[thread overview]
Message-ID: <f4caa3f6-66d2-db44-0e21-900fe663da48@embeddedor.com> (raw)
In-Reply-To: <20230810204953.wwwvbl57m3cebf27@google.com>



On 8/10/23 14:49, Justin Stitt wrote:
> On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote:
>> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
>>> One-element and zero-length arrays are deprecated. So, replace
>>> one-element array in struct i40e_profile_segment with flexible-array
>>> member.
>>>
>>> This results in no differences in binary output.
>>>
>>> Link: https://github.com/KSPP/linux/issues/335
>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>> ---
>>>   drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> Tested-by: Justin Stitt <justinstitt@google.com>
> Whoops, this should be:
> Reviewed-by: Justin Stitt <justinstitt@google.com>
> 
> I did not test, I just verified there are no binary differences produced
> by this patch.

In that case, `Build-tested-by` seems more appropriate.

Anyways, the series has been applied already.

--
Gustavo


  reply	other threads:[~2023-08-10 21:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  5:04 [PATCH 0/4][next] i40e: Replace one-element arrays with flexible-array members Gustavo A. R. Silva
2023-08-02  5:05 ` [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header Gustavo A. R. Silva
2023-08-02 15:18   ` Simon Horman
2023-08-10 10:04   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-08-02  5:05 ` [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment Gustavo A. R. Silva
2023-08-02 15:23   ` Simon Horman
2023-08-10 10:06   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-08-10 17:34   ` Justin Stitt
2023-08-10 20:49     ` Justin Stitt
2023-08-10 21:51       ` Gustavo A. R. Silva [this message]
2023-08-02  5:06 ` [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table Gustavo A. R. Silva
2023-08-02 15:23   ` Simon Horman
2023-08-10 10:08   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-08-02  5:07 ` [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section Gustavo A. R. Silva
2023-08-02 15:24   ` Simon Horman
2023-08-10 10:13   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4caa3f6-66d2-db44-0e21-900fe663da48@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gustavoars@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=justinstitt@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox