From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79AECC61DA4 for ; Thu, 2 Feb 2023 20:34:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbjBBUeD (ORCPT ); Thu, 2 Feb 2023 15:34:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbjBBUeC (ORCPT ); Thu, 2 Feb 2023 15:34:02 -0500 Received: from omta035.useast.a.cloudfilter.net (omta035.useast.a.cloudfilter.net [44.202.169.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A88B96D046 for ; Thu, 2 Feb 2023 12:34:01 -0800 (PST) Received: from eig-obgw-5020a.ext.cloudfilter.net ([10.0.29.203]) by cmsmtp with ESMTP id NWPIpJbuVsq1sNgHQptwKG; Thu, 02 Feb 2023 20:34:00 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTP id NgHPpPeUpAkFWNgHPpR8yu; Thu, 02 Feb 2023 20:34:00 +0000 X-Authority-Analysis: v=2.4 cv=EsbBEAQA c=1 sm=1 tr=0 ts=63dc1e38 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=wTog8WU66it3cfrESHnF4A==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=m04uMKEZRckA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=mDV3o1hIAAAA:8 a=VwQbUJbxAAAA:8 a=gwZbGxDKoGpvoHXj0fsA:9 a=QEXdDO2ut3YA:10 a=t_mPKkL_zAAA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=havDD7BADH0COSYVLMyQg91Hn9SZSCTeeTvqOnemfFo=; b=sE6KXZogcskAgJDd4SwF9bxrs5 qbZ/IL1PnJ7ZSPn9AgsXl/qsvuTDTtqY/o0oUDV2Laju4nvIOkPs8EfzCIOAMtFFuvTTwvQs0NGbP 1b3I//jSpeZxL2mU3/v9XWzkywsGZ1WE0SehkfTcmMJtttJdZr40vTTUV5NWlWaJZ3N483NZJ3Gnf RSSEqwNgXazUoTRP09bgS4Ah49YZB7i/3FsTEqjRcfkC74t9qzPKMJI6uHXRb0liNV5UMAK2OzdQ3 uoF+YMPPNhEJ2BT1yAl9B2cR+4ojKQcotZ2T1MyflqEZGxzILkuva43nt+RMuyGwLx/fkDGWZK5Vk QVBR5NDQ==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:48834 helo=[192.168.15.7]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1pNgHO-002ALM-V6; Thu, 02 Feb 2023 14:33:59 -0600 Message-ID: Date: Thu, 2 Feb 2023 14:34:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH][next] ASoC: uapi: Replace zero-length arrays with __DECLARE_FLEX_ARRAY() helper Content-Language: en-US To: "Gustavo A. R. Silva" , Jaroslav Kysela , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: From: "Gustavo A. R. Silva" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1pNgHO-002ALM-V6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.7]) [187.162.31.110]:48834 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 1 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOriajqx6xuInt9w2Abc+zqsxkX6+DasiLGAPcMGBjMifw2cN9BusBwotFkq17srkMMjE7yzocDnfH0Y6F/a4QuaEzI1+pBDDpBNlosL4sl01qNJ8uay jy7U9sla3ZJykoihRrrAjzjsII5sCCMdYN6ZgRjXXs2i06xBKbFq2+vd3a+H3bT++OpfbNFJ06FyfxKSFPkg3E3TmLG4Bug37+ZIVz4WU4eOSboNgt4b8hbH Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi Takashi, I wonder if this can go through your tree. It's already been reviewed by a couple of people. :) Thanks -- Gustavo On 9/26/22 18:18, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length arrays > declarations in anonymous union with the new __DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for flexible-array members in unions. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://github.com/KSPP/linux/issues/227 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva > --- > include/uapi/sound/asoc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h > index 053949287ce8..dd8ad790fc15 100644 > --- a/include/uapi/sound/asoc.h > +++ b/include/uapi/sound/asoc.h > @@ -226,9 +226,9 @@ struct snd_soc_tplg_vendor_array { > __le32 type; /* SND_SOC_TPLG_TUPLE_TYPE_ */ > __le32 num_elems; /* number of elements in array */ > union { > - struct snd_soc_tplg_vendor_uuid_elem uuid[0]; > - struct snd_soc_tplg_vendor_value_elem value[0]; > - struct snd_soc_tplg_vendor_string_elem string[0]; > + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_uuid_elem, uuid); > + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_value_elem, value); > + __DECLARE_FLEX_ARRAY(struct snd_soc_tplg_vendor_string_elem, string); > }; > } __attribute__((packed)); >