From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kees Cook <kees@kernel.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: Add __nonstring annotations for unterminated strings
Date: Fri, 11 Apr 2025 21:55:24 -0400 [thread overview]
Message-ID: <yq1lds6i1ol.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <202504071136.73E5C22D0B@keescook> (Kees Cook's message of "Mon, 7 Apr 2025 11:37:54 -0700")
Kees,
>> > When a character array without a terminating NUL character has a
>> > static initializer, GCC 15's -Wunterminated-string-initialization
>> > will only warn if the array lacks the "nonstring" attribute[1].
>> > Mark the arrays with __nonstring to and correctly identify the char
>> > array as "not a C string" and thereby eliminate the warning.
Applied to 6.16/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2025-04-12 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 22:25 [PATCH] scsi: pm80xx: Add __nonstring annotations for unterminated strings Kees Cook
2025-03-10 22:38 ` James Bottomley
2025-04-07 18:37 ` Kees Cook
2025-04-12 1:55 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lds6i1ol.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox