From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Brian Cain" Subject: RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h Date: Mon, 23 Mar 2020 16:46:17 -0500 Message-ID: <0cc301d6015c$7e756490$7b602db0$@codeaurora.org> References: <20200321112544.878032781@linutronix.de> <20200321113241.531525286@linutronix.de> Reply-To: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585000016; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Reply-To: Sender; bh=ZNpFv8n1vyNtNLXdZYwI5uo1FnppFNp10NWp9MPwYDo=; b=pV5wXOXNdhL3eVZsNo55Jkdbpsbs42F62/xWygxj9c/eYVWMohS4o+mhwlvJyHV24YPdMjaD W16jdED42Kc62TXTAAsR+FdFaDvndEXAjROPVUy+eo1TudXeGAQNEUZhH9VsoRGIpVCU/yYV SHklrUiCw9e2cryiSqklyZqDZbg= In-Reply-To: <20200321113241.531525286@linutronix.de> Content-Language: en-us Sender: linux-acpi-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: 'Thomas Gleixner' , 'LKML' Cc: 'Peter Zijlstra' , 'Ingo Molnar' , 'Sebastian Siewior' , 'Linus Torvalds' , 'Joel Fernandes' , 'Oleg Nesterov' , 'Davidlohr Bueso' , 'kbuild test robot' , linux-hexagon@vger.kernel.org, 'Logan Gunthorpe' , 'Bjorn Helgaas' , 'Kurt Schwemmer' , linux-pci@vger.kernel.org, 'Greg Kroah-Hartman' , 'Felipe Balbi' , linux-usb@vger.kernel.org, 'Kalle Valo' , "'David S. Miller'" , linux-wireless@vger.k > -----Original Message----- > From: Thomas Gleixner ... > Subject: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h > > From: Sebastian Andrzej Siewior > > The defconfig compiles without linux/mm.h. With mm.h included the include > chain leands to: > | CC kernel/locking/percpu-rwsem.o > | In file included from include/linux/huge_mm.h:8, > | from include/linux/mm.h:567, > | from arch/hexagon/include/asm/uaccess.h:, > | from include/linux/uaccess.h:11, > | from include/linux/sched/task.h:11, > | from include/linux/sched/signal.h:9, > | from include/linux/rcuwait.h:6, > | from include/linux/percpu-rwsem.h:8, > | from kernel/locking/percpu-rwsem.c:6: > | include/linux/fs.h:1422:29: error: array type has incomplete element type > 'struct percpu_rw_semaphore' > | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS]; > > once rcuwait.h includes linux/sched/signal.h. > > Remove the linux/mm.h include. > > Reported-by: kbuild test robot > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Brian Cain > Cc: linux-hexagon@vger.kernel.org > --- > V3: New patch > --- > arch/hexagon/include/asm/uaccess.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/hexagon/include/asm/uaccess.h > b/arch/hexagon/include/asm/uaccess.h > index 00cb38faad0c4..c1019a736ff13 100644 > --- a/arch/hexagon/include/asm/uaccess.h > +++ b/arch/hexagon/include/asm/uaccess.h > @@ -10,7 +10,6 @@ > /* > * User space memory access functions > */ > -#include > #include > > /* > -- > 2.26.0.rc2 > Acked-by: Brian Cain