[PATCH] hexagon: correct type on pgd copy

[PATCH] hexagon: correct type on pgd copy

[Ilia Mirkin]

swapper_pg_dir is an array of pgd_t, not pgd_t*. This has no actual
effect since sizeof(pgd_t) == sizeof(pgd_t*), but unconfuses tools that
check types.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
---

Looks like I wrote this ~2 years ago, when I was playing around with spatch,
but forgot to send it out (along with a few other patches which no longer
applied). This still seems valid though.

 arch/hexagon/include/asm/pgalloc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h
index 4c9d382..77da3b0 100644
--- a/arch/hexagon/include/asm/pgalloc.h
+++ b/arch/hexagon/include/asm/pgalloc.h
@@ -45,7 +45,7 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm)
 	 * map with a copy of the kernel's persistent map.
 	 */
 
-	memcpy(pgd, swapper_pg_dir, PTRS_PER_PGD*sizeof(pgd_t *));
+	memcpy(pgd, swapper_pg_dir, PTRS_PER_PGD*sizeof(pgd_t));
 	mm->context.generation = kmap_generation;
 
 	/* Physical version is what is passed to virtual machine on switch */
-- 
1.8.3.2

Re: [PATCH] hexagon: correct type on pgd copy

[rkuo]

On Thu, Dec 05, 2013 at 09:13:25PM -0500, Ilia Mirkin wrote:
> swapper_pg_dir is an array of pgd_t, not pgd_t*. This has no actual
> effect since sizeof(pgd_t) == sizeof(pgd_t*), but unconfuses tools that
> check types.
> 
> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
> ---
> 
> Looks like I wrote this ~2 years ago, when I was playing around with spatch,
> but forgot to send it out (along with a few other patches which no longer
> applied). This still seems valid though.
> 
>  arch/hexagon/include/asm/pgalloc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks! I'll try to send this out with my next pull request.


Acked-by: Richard Kuo <rkuo@codeaurora.org>

-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation