From: Paul Bolle <pebolle@tiscali.nl>
To: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org
Subject: hexagon: CONFIG_PAGE_SIZE_1MB?
Date: Sat, 17 May 2014 13:32:43 +0200 [thread overview]
Message-ID: <1400326363.13824.8.camel@x220> (raw)
Richard,
0) There are two checks for CONFIG_PAGE_SIZE_1MB in Linux' hexagon code.
But there's no Kconfig symbol PAGE_SIZE_1MB.
1) There are two trivial solutions to this issue:
diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
index 0fd6138f6203..fe3c235930a5 100644
--- a/arch/hexagon/Kconfig
+++ b/arch/hexagon/Kconfig
@@ -148,6 +148,9 @@ config PAGE_SIZE_64KB
config PAGE_SIZE_256KB
bool "256KB"
+config PAGE_SIZE_1MB
+ bool "1MB"
+
endchoice
source "mm/Kconfig"
and
diff --git a/arch/hexagon/include/asm/page.h b/arch/hexagon/include/asm/page.h
index 93f5669b4aa1..7bcec3c0447c 100644
--- a/arch/hexagon/include/asm/page.h
+++ b/arch/hexagon/include/asm/page.h
@@ -45,11 +45,6 @@
#define HEXAGON_L1_PTE_SIZE __HVM_PDE_S_256KB
#endif
-#ifdef CONFIG_PAGE_SIZE_1MB
-#define PAGE_SHIFT 20
-#define HEXAGON_L1_PTE_SIZE __HVM_PDE_S_1MB
-#endif
-
/*
* These should be defined in hugetlb.h, but apparently not.
* "Huge" for us should be 4MB or 16MB, which are both represented
diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h
index d8bd54fa431e..861a993afb7e 100644
--- a/arch/hexagon/include/asm/pgtable.h
+++ b/arch/hexagon/include/asm/pgtable.h
@@ -111,10 +111,6 @@ extern unsigned long zero_page_mask;
#define PTRS_PER_PTE 16
#endif
-#ifdef CONFIG_PAGE_SIZE_1MB
-#define PTRS_PER_PTE 4
-#endif
-
/* Any bigger and the PTE disappears. */
#define pgd_ERROR(e) \
printk(KERN_ERR "%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__,\
2) Which trivial solution would you prefer?
Paul Bolle
next reply other threads:[~2014-05-17 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 11:32 Paul Bolle [this message]
2014-05-18 15:53 ` hexagon: CONFIG_PAGE_SIZE_1MB? Rob Landley
2014-05-21 0:25 ` rkuo
2014-05-23 14:37 ` [PATCH] Hexagon: remove checks for CONFIG_PAGE_SIZE_1MB Paul Bolle
2014-05-29 2:31 ` rkuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400326363.13824.8.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-hexagon@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).