From: Sudeep Holla <sudeep.holla@arm.com>
To: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: [PATCH] Hexagon: kernel: use IRQCHIP_SKIP_SET_WAKE instead of irq_set_wake callback
Date: Mon, 15 Jun 2015 17:56:17 +0100 [thread overview]
Message-ID: <1434387377-17183-1-git-send-email-sudeep.holla@arm.com> (raw)
Commit 60f96b41f71d ("genirq: Add IRQCHIP_SKIP_SET_WAKE flag")
introduced a new flag to skip the irq_set_wake callback in the irqchip
core to avoid adding dummy irq_set_wake in the irqchip implementations.
This patch removes the dummy callback and sets the IRQCHIP_SKIP_SET_WAKE
flags.
Cc: Richard Kuo <rkuo@codeaurora.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/hexagon/kernel/irq_cpu.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/arch/hexagon/kernel/irq_cpu.c b/arch/hexagon/kernel/irq_cpu.c
index 85883e1fdc12..36b8ccfda43a 100644
--- a/arch/hexagon/kernel/irq_cpu.c
+++ b/arch/hexagon/kernel/irq_cpu.c
@@ -43,24 +43,12 @@ static void eoi_irq(struct irq_data *data)
__vmintop_globen((long) data->irq);
}
-/* Power mamangement wake call. We don't need this, however,
- * if this is absent, then an -ENXIO error is returned to the
- * msm_serial driver, and it fails to correctly initialize.
- * This is a bug in the msm_serial driver, but, for now, we
- * work around it here, by providing this bogus handler.
- * XXX FIXME!!! remove this when msm_serial is fixed.
- */
-static int set_wake(struct irq_data *data, unsigned int on)
-{
- return 0;
-}
-
static struct irq_chip hexagon_irq_chip = {
.name = "HEXAGON",
.irq_mask = mask_irq,
.irq_unmask = unmask_irq,
- .irq_set_wake = set_wake,
- .irq_eoi = eoi_irq
+ .irq_eoi = eoi_irq,
+ .flags = IRQCHIP_SKIP_SET_WAKE,
};
/**
--
1.9.1
next reply other threads:[~2015-06-15 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 16:56 Sudeep Holla [this message]
2015-06-18 17:45 ` [PATCH] Hexagon: kernel: use IRQCHIP_SKIP_SET_WAKE instead of irq_set_wake callback rkuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434387377-17183-1-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).