Re: [PATCH v2 12/28] openrisc: introduce arch_zone_limits_init()

Stafford Horne
2026-01-03T05:36:32Z

On Fri, Jan 02, 2026 at 08:59:48AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Move calculations of zone limits to a dedicated arch_zone_limits_init()
> function.
>
> Later MM core will use this function as an architecture specific callback
> during nodes and zones initialization and thus there won't be a need to
> call free_area_init() from every architecture.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> arch/openrisc/mm/init.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index 9382d9a0ec78..67de93e7a685 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -39,15 +39,19 @@
>
> int mem_init_done;
>
> -static void __init zone_sizes_init(void)
> +void __init arch_zone_limits_init(unsigned long *max_zone_pfns)
> {
> - unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
> -
> /*
> * We use only ZONE_NORMAL
> */
> - max_zone_pfn[ZONE_NORMAL] = max_low_pfn;
> + max_zone_pfns[ZONE_NORMAL] = max_low_pfn;
> +}
> +
> +static void __init zone_sizes_init(void)
> +{
> + unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
>
> + arch_zone_limits_init(max_zone_pfn);
> free_area_init(max_zone_pfn);
> }

Thanks, this looks like a good cleanup.

Acked-by: Stafford Horne <shorne@gmail.com>