[PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[Richard Weinberger]

get_signal_to_deliver() calls try_to_freeze() which might sleep.

Cc: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/hexagon/kernel/signal.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
index 434866e..8403bfd 100644
--- a/arch/hexagon/kernel/signal.c
+++ b/arch/hexagon/kernel/signal.c
@@ -22,6 +22,7 @@
 #include <linux/syscalls.h>
 #include <linux/freezer.h>
 #include <linux/tracehook.h>
+#include <linux/irqflags.h>
 #include <asm/registers.h>
 #include <asm/thread_info.h>
 #include <asm/unistd.h>
@@ -267,6 +268,8 @@ no_restart:
 
 void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
 {
+	local_irq_enable();
+
 	if (thread_info_flags & _TIF_SIGPENDING)
 		do_signal(regs);
 
-- 
1.7.7.3

[PATCH 17/20] hexagon: Do not call try_to_freeze() in do_signal()

[Richard Weinberger]

get_signal_to_deliver() already calls try_to_freeze(), there is no
need to call it directly.

Cc: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/hexagon/kernel/signal.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
index 8403bfd..9783cfa 100644
--- a/arch/hexagon/kernel/signal.c
+++ b/arch/hexagon/kernel/signal.c
@@ -20,7 +20,6 @@
 
 #include <linux/linkage.h>
 #include <linux/syscalls.h>
-#include <linux/freezer.h>
 #include <linux/tracehook.h>
 #include <linux/irqflags.h>
 #include <asm/registers.h>
@@ -210,9 +209,6 @@ static void do_signal(struct pt_regs *regs)
 	if (!user_mode(regs))
 		return;
 
-	if (try_to_freeze())
-		goto no_signal;
-
 	signo = get_signal_to_deliver(&info, &sigact, regs, NULL);
 
 	if (signo > 0) {
@@ -237,7 +233,6 @@ static void do_signal(struct pt_regs *regs)
 		return;
 	}
 
-no_signal:
 	/*
 	 * If we came from a system call, handle the restart.
 	 */
-- 
1.7.7.3

Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[Richard Kuo]

On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() calls try_to_freeze() which might sleep.
> 
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/hexagon/kernel/signal.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 434866e..8403bfd 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -22,6 +22,7 @@
>  #include <linux/syscalls.h>
>  #include <linux/freezer.h>
>  #include <linux/tracehook.h>
> +#include <linux/irqflags.h>
>  #include <asm/registers.h>
>  #include <asm/thread_info.h>
>  #include <asm/unistd.h>
> @@ -267,6 +268,8 @@ no_restart:
>  
>  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
>  {
> +	local_irq_enable();
> +
>  	if (thread_info_flags & _TIF_SIGPENDING)
>  		do_signal(regs);
>  
> -- 
> 1.7.7.3
> 

Signed-off-by: Richard Kuo <rkuo@codeaurora.org>


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 17/20] hexagon: Do not call try_to_freeze() in do_signal()

[Richard Kuo]

On Sat, May 26, 2012 at 12:04:33AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() already calls try_to_freeze(), there is no
> need to call it directly.
> 
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/hexagon/kernel/signal.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 8403bfd..9783cfa 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -20,7 +20,6 @@
>  
>  #include <linux/linkage.h>
>  #include <linux/syscalls.h>
> -#include <linux/freezer.h>
>  #include <linux/tracehook.h>
>  #include <linux/irqflags.h>
>  #include <asm/registers.h>
> @@ -210,9 +209,6 @@ static void do_signal(struct pt_regs *regs)
>  	if (!user_mode(regs))
>  		return;
>  
> -	if (try_to_freeze())
> -		goto no_signal;
> -
>  	signo = get_signal_to_deliver(&info, &sigact, regs, NULL);
>  
>  	if (signo > 0) {
> @@ -237,7 +233,6 @@ static void do_signal(struct pt_regs *regs)
>  		return;
>  	}
>  
> -no_signal:
>  	/*
>  	 * If we came from a system call, handle the restart.
>  	 */
> -- 
> 1.7.7.3
> 

Signed-off-by: Richard Kuo <rkuo@codeaurora.org>


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[David Brown]

On Fri, Jun 01, 2012 at 12:54:59PM -0500, Richard Kuo wrote:
> On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> > get_signal_to_deliver() calls try_to_freeze() which might sleep.
> > 
> > Cc: Richard Kuo <rkuo@codeaurora.org>
> > Cc: linux-hexagon@vger.kernel.org
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > ---
> >  arch/hexagon/kernel/signal.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> > index 434866e..8403bfd 100644
> > --- a/arch/hexagon/kernel/signal.c
> > +++ b/arch/hexagon/kernel/signal.c
> > @@ -22,6 +22,7 @@
> >  #include <linux/syscalls.h>
> >  #include <linux/freezer.h>
> >  #include <linux/tracehook.h>
> > +#include <linux/irqflags.h>
> >  #include <asm/registers.h>
> >  #include <asm/thread_info.h>
> >  #include <asm/unistd.h>
> > @@ -267,6 +268,8 @@ no_restart:
> >  
> >  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
> >  {
> > +	local_irq_enable();
> > +
> >  	if (thread_info_flags & _TIF_SIGPENDING)
> >  		do_signal(regs);
> >  
> > -- 
> > 1.7.7.3
> 
> Signed-off-by: Richard Kuo <rkuo@codeaurora.org>

Did you mean Acked-by?  Replying to an email with a Signed-off-by
doesn't mean anything.  If you're pulling the patch into your own
tree, add the SoB at that point.  If you want to reply that you've
accepted a patch, just say so in English.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[Richard Kuo]

On Fri, Jun 01, 2012 at 11:42:12AM -0700, David Brown wrote:
> On Fri, Jun 01, 2012 at 12:54:59PM -0500, Richard Kuo wrote:
> > On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> > > get_signal_to_deliver() calls try_to_freeze() which might sleep.
> > > 
> > > Cc: Richard Kuo <rkuo@codeaurora.org>
> > > Cc: linux-hexagon@vger.kernel.org
> > > Signed-off-by: Richard Weinberger <richard@nod.at>
> > > ---
> > >  arch/hexagon/kernel/signal.c |    3 +++
> > >  1 files changed, 3 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> > > index 434866e..8403bfd 100644
> > > --- a/arch/hexagon/kernel/signal.c
> > > +++ b/arch/hexagon/kernel/signal.c
> > > @@ -22,6 +22,7 @@
> > >  #include <linux/syscalls.h>
> > >  #include <linux/freezer.h>
> > >  #include <linux/tracehook.h>
> > > +#include <linux/irqflags.h>
> > >  #include <asm/registers.h>
> > >  #include <asm/thread_info.h>
> > >  #include <asm/unistd.h>
> > > @@ -267,6 +268,8 @@ no_restart:
> > >  
> > >  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
> > >  {
> > > +	local_irq_enable();
> > > +
> > >  	if (thread_info_flags & _TIF_SIGPENDING)
> > >  		do_signal(regs);
> > >  
> > > -- 
> > > 1.7.7.3
> > 
> > Signed-off-by: Richard Kuo <rkuo@codeaurora.org>
> 
> Did you mean Acked-by?  Replying to an email with a Signed-off-by
> doesn't mean anything.  If you're pulling the patch into your own
> tree, add the SoB at that point.  If you want to reply that you've
> accepted a patch, just say so in English.
> 
> David

Doh, sorry, I really meant Acked-by.  Thanks for catching that.


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqs disabled

[Richard Kuo]

On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() calls try_to_freeze() which might sleep.
> 
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/hexagon/kernel/signal.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 434866e..8403bfd 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -22,6 +22,7 @@
>  #include <linux/syscalls.h>
>  #include <linux/freezer.h>
>  #include <linux/tracehook.h>
> +#include <linux/irqflags.h>
>  #include <asm/registers.h>
>  #include <asm/thread_info.h>
>  #include <asm/unistd.h>
> @@ -267,6 +268,8 @@ no_restart:
>  
>  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
>  {
> +	local_irq_enable();
> +
>  	if (thread_info_flags & _TIF_SIGPENDING)
>  		do_signal(regs);
>  
> -- 
> 1.7.7.3
> 

Acked-by:  Richard Kuo <rkuo@codeaurora.org>


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 17/20] hexagon: Do not call try_to_freeze() in do_signal()

[Richard Kuo]

On Sat, May 26, 2012 at 12:04:33AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() already calls try_to_freeze(), there is no
> need to call it directly.
> 
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/hexagon/kernel/signal.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 8403bfd..9783cfa 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -20,7 +20,6 @@
>  
>  #include <linux/linkage.h>
>  #include <linux/syscalls.h>
> -#include <linux/freezer.h>
>  #include <linux/tracehook.h>
>  #include <linux/irqflags.h>
>  #include <asm/registers.h>
> @@ -210,9 +209,6 @@ static void do_signal(struct pt_regs *regs)
>  	if (!user_mode(regs))
>  		return;
>  
> -	if (try_to_freeze())
> -		goto no_signal;
> -
>  	signo = get_signal_to_deliver(&info, &sigact, regs, NULL);
>  
>  	if (signo > 0) {
> @@ -237,7 +233,6 @@ static void do_signal(struct pt_regs *regs)
>  		return;
>  	}
>  
> -no_signal:
>  	/*
>  	 * If we came from a system call, handle the restart.
>  	 */
> -- 
> 1.7.7.3
> 

Acked-by: Richard Kuo <rkuo@codeaurora.org>

-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.