From: Richard Kuo <rkuo@codeaurora.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-hexagon@vger.kernel.org,
David Howells <dhowells@redhat.com>,
linux-am33-list@redhat.com, Chris Metcalf <cmetcalf@tilera.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h
Date: Thu, 21 Jun 2012 14:46:38 -0500 [thread overview]
Message-ID: <20120621194638.GB19619@codeaurora.org> (raw)
In-Reply-To: <1340306466.1773.60.camel@x61.thuisdomein>
On Thu, Jun 21, 2012 at 09:21:06PM +0200, Paul Bolle wrote:
> mn10300 has a header (in its include/asm directory) that is a thin
> wrapper around asm-generic/ipc.h. This wrapper is useless, since that
> header doesn't exist. It is also unused (no file includes asm/ipc.h).
>
> hexagon and tile generate similar headers at build time (using a
> generic-y entry in include/asm/Kbuild). These generated headers are
> useless and unused too.
>
> Remove this header and these generic-y entries.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> arch/hexagon/include/asm/Kbuild | 1 -
> arch/mn10300/include/asm/ipc.h | 1 -
> arch/tile/include/asm/Kbuild | 1 -
> 3 files changed, 0 insertions(+), 3 deletions(-)
> delete mode 100644 arch/mn10300/include/asm/ipc.h
>
> diff --git a/arch/hexagon/include/asm/Kbuild b/arch/hexagon/include/asm/Kbuild
> index 8ecd202..0690642 100644
> --- a/arch/hexagon/include/asm/Kbuild
> +++ b/arch/hexagon/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += ioctl.h
> generic-y += ioctls.h
> generic-y += iomap.h
> generic-y += ipcbuf.h
> -generic-y += ipc.h
> generic-y += irq_regs.h
> generic-y += kdebug.h
> generic-y += kmap_types.h
> diff --git a/arch/mn10300/include/asm/ipc.h b/arch/mn10300/include/asm/ipc.h
> deleted file mode 100644
> index a46e3d9..0000000
> --- a/arch/mn10300/include/asm/ipc.h
> +++ /dev/null
> @@ -1 +0,0 @@
> -#include <asm-generic/ipc.h>
> diff --git a/arch/tile/include/asm/Kbuild b/arch/tile/include/asm/Kbuild
> index 143473e..ab7640a 100644
> --- a/arch/tile/include/asm/Kbuild
> +++ b/arch/tile/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += fb.h
> generic-y += fcntl.h
> generic-y += ioctl.h
> generic-y += ioctls.h
> -generic-y += ipc.h
> generic-y += ipcbuf.h
> generic-y += irq_regs.h
> generic-y += kdebug.h
> --
> 1.7.7.6
>
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-06-21 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 19:21 [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h Paul Bolle
2012-06-21 19:46 ` Richard Kuo [this message]
2012-06-21 19:54 ` Chris Metcalf
2012-06-21 23:08 ` David Howells
2012-06-28 9:30 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621194638.GB19619@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=cmetcalf@tilera.com \
--cc=dhowells@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).