From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Date: Thu, 23 May 2013 10:05:34 +0100 Message-ID: <20130523090534.GJ18614@n2100.arm.linux.org.uk> References: <519DCBEF.3090208@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=u6bqXITt0qZvOCha9SwJlRg4ZTnwcpYfGgR6LM3Vbok=; b=MStONF5GJlrj4mU1AVh2zmgWxIWokK69gBAuw7NTvD2/fpVTcl/EyEjKSTRAH1cBQboiquBmYuB1L4KOXHbUSBiVUOK3XwTe85nN22r//rrGfloLOYftfP+I591lfvPZTDwCS8+biHSWIj2CmzJwGeDYPQVnO7U6HHByB5d8tUc=; Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org Errors-To: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org To: Geert Uytterhoeven Cc: Linux-sh list , Catalin Marinas , Benjamin Herrenschmidt , Chen Gang , Heiko Carstens , "paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org" , "H. Peter Anvin" , Michel Lespinasse , Hans-Christian Egtvedt , Linux-Arch , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uml-devel , Yoshinori Sato , Richard Weinberger , Helge Deller , the arch/x86 maintainers , "James E.J. Bottomley" , "mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , Frederic Weisbecker On Thu, May 23, 2013 at 10:40:29AM +0200, Geert Uytterhoeven wrote: > On Thu, May 23, 2013 at 9:57 AM, Chen Gang wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, reducing > > - the size of your kernel image and potentially quietly ignoring > > - numerous fatal conditions. You should only consider disabling this > > - option for embedded systems with no facilities for reporting errors. > > - Just say Y. > > ... It's about reducing memory size on devices where you can't show bug or > warning messages. And turning off CONFIG_BUG causes lots of warning messages at compile time about functions which are returning nothing which shouldn't. The problem is: trying to fix that _will_ mean the result is a larger kernel than if you just do the usual arch-implemented thing of placing an defined faulting instruction at the BUG() site - which defeats the purpose of turning off CONFIG_BUG. Therefore, it's better that CONFIG_BUG always be y and we stop kidding ourselves that it's possible to turn this off and safely save space.