From: rkuo <rkuo@codeaurora.org>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-hexagon@vger.kernel.org
Subject: Re: [PATCH 07/21] hexagon: remove unnecessary prom.h includes
Date: Mon, 30 Sep 2013 15:21:12 -0500 [thread overview]
Message-ID: <20130930202112.GA4839@codeaurora.org> (raw)
In-Reply-To: <1380221456-11192-8-git-send-email-robherring2@gmail.com>
On Thu, Sep 26, 2013 at 01:50:42PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Hexagon does not have a prom.h header, so it is probably broken with
> CONFIG_OF enabled. In any case, remove unnecessary prom.h include in
> preparation to make prom.h optional.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> ---
> arch/hexagon/kernel/setup.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/hexagon/kernel/setup.c b/arch/hexagon/kernel/setup.c
> index 29d1f1b..0e7c1db 100644
> --- a/arch/hexagon/kernel/setup.c
> +++ b/arch/hexagon/kernel/setup.c
> @@ -32,9 +32,6 @@
> #include <asm/hexagon_vm.h>
> #include <asm/vm_mmu.h>
> #include <asm/time.h>
> -#ifdef CONFIG_OF
> -#include <asm/prom.h>
> -#endif
>
> char cmd_line[COMMAND_LINE_SIZE];
> static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
> --
> 1.8.1.2
>
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2013-09-30 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1380221456-11192-1-git-send-email-robherring2@gmail.com>
2013-09-26 18:50 ` [PATCH 07/21] hexagon: remove unnecessary prom.h includes Rob Herring
2013-09-30 20:21 ` rkuo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930202112.GA4839@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).