* [PATCH] arch: hexagon: Kconfig: add HAVE_DMA_ATTR in Kconfig and remove "linux/dma-mapping.h" from "asm/dma-mapping.h" @ 2013-11-19 4:57 Chen Gang 2013-11-25 1:19 ` rkuo 0 siblings, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-19 4:57 UTC (permalink / raw) To: Richard Kuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org When HAS_DMA, and also need use generic implementation, HAVE_DMA_ATTR must be enabled, or can not pass compiling with allmodconfig, the related error: CC [M] drivers/ata/libata-core.o drivers/ata/libata-core.c: In function 'ata_sg_clean': drivers/ata/libata-core.c:4598:3: error: implicit declaration of function 'dma_unmap_sg' [-Werror=implicit-function-declaration] drivers/ata/libata-core.c: In function 'ata_sg_setup': drivers/ata/libata-core.c:4708:2: error: implicit declaration of function 'dma_map_sg' [-Werror=implicit-function-declaration] "linux/dma-mapping.h" will include "asm/dma-mapping.h", so need remove "linux/dma-mapping.h" from "asm/dma-mapping.h", Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/Kconfig | 1 + arch/hexagon/include/asm/dma-mapping.h | 1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig index 09df260..fbc5c78 100644 --- a/arch/hexagon/Kconfig +++ b/arch/hexagon/Kconfig @@ -28,6 +28,7 @@ config HEXAGON select GENERIC_CLOCKEVENTS_BROADCAST select MODULES_USE_ELF_RELA select GENERIC_CPU_DEVICES + select HAVE_DMA_ATTRS ---help--- Qualcomm Hexagon is a processor architecture designed for high performance and low power across a wide variety of applications. diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h index 85e9935..1696542 100644 --- a/arch/hexagon/include/asm/dma-mapping.h +++ b/arch/hexagon/include/asm/dma-mapping.h @@ -25,7 +25,6 @@ #include <linux/cache.h> #include <linux/mm.h> #include <linux/scatterlist.h> -#include <linux/dma-mapping.h> #include <linux/dma-debug.h> #include <linux/dma-attrs.h> #include <asm/io.h> -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: hexagon: Kconfig: add HAVE_DMA_ATTR in Kconfig and remove "linux/dma-mapping.h" from "asm/dma-mapping.h" 2013-11-19 4:57 [PATCH] arch: hexagon: Kconfig: add HAVE_DMA_ATTR in Kconfig and remove "linux/dma-mapping.h" from "asm/dma-mapping.h" Chen Gang @ 2013-11-25 1:19 ` rkuo 2013-11-25 2:39 ` [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" Chen Gang 2013-11-26 4:07 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" Chen Gang 0 siblings, 2 replies; 14+ messages in thread From: rkuo @ 2013-11-25 1:19 UTC (permalink / raw) To: Chen Gang; +Cc: linux-hexagon, linux-kernel@vger.kernel.org On Tue, Nov 19, 2013 at 12:57:27PM +0800, Chen Gang wrote: > When HAS_DMA, and also need use generic implementation, HAVE_DMA_ATTR > must be enabled, or can not pass compiling with allmodconfig, the > related error: > > CC [M] drivers/ata/libata-core.o > drivers/ata/libata-core.c: In function 'ata_sg_clean': > drivers/ata/libata-core.c:4598:3: error: implicit declaration of function 'dma_unmap_sg' [-Werror=implicit-function-declaration] > drivers/ata/libata-core.c: In function 'ata_sg_setup': > drivers/ata/libata-core.c:4708:2: error: implicit declaration of function 'dma_map_sg' [-Werror=implicit-function-declaration] > > "linux/dma-mapping.h" will include "asm/dma-mapping.h", so need remove > "linux/dma-mapping.h" from "asm/dma-mapping.h", > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" 2013-11-25 1:19 ` rkuo @ 2013-11-25 2:39 ` Chen Gang 2013-11-25 2:40 ` [PATCH 1/2] " Chen Gang 2013-11-26 4:07 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" Chen Gang 1 sibling, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-25 2:39 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org Append "vm_" to all enum members (which are too common to make conflict with another sub-systems). The related error with allmodconfig: CC [M] drivers/md/raid1.o drivers/md/raid1.c:1440:13: error: 'status' redeclared as different kind of symbol arch/hexagon/include/asm/hexagon_vm.h:76:2: note: previous definition of 'status' was here Also fix a typo issue: use 'affinity' instead of 'locdis' for __vmintop_affinity() in "hexagon_vm.h" Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/hexagon_vm.h | 72 ++++++++++++++++---------------- 1 files changed, 36 insertions(+), 36 deletions(-) ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" 2013-11-25 2:39 ` [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" Chen Gang @ 2013-11-25 2:40 ` Chen Gang 2013-11-25 2:41 ` [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() " Chen Gang 2013-11-26 4:36 ` [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" " Chen Gang 0 siblings, 2 replies; 14+ messages in thread From: Chen Gang @ 2013-11-25 2:40 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org Append "vm_" to all enum members (which are too common to make conflict with another sub-systems). The related error with allmodconfig: CC [M] drivers/md/raid1.o drivers/md/raid1.c:1440:13: error: 'status' redeclared as different kind of symbol arch/hexagon/include/asm/hexagon_vm.h:76:2: note: previous definition of 'status' was here Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/hexagon_vm.h | 70 ++++++++++++++++---------------- 1 files changed, 35 insertions(+), 35 deletions(-) diff --git a/arch/hexagon/include/asm/hexagon_vm.h b/arch/hexagon/include/asm/hexagon_vm.h index 67bb6d6..e1e0470 100644 --- a/arch/hexagon/include/asm/hexagon_vm.h +++ b/arch/hexagon/include/asm/hexagon_vm.h @@ -55,27 +55,27 @@ #ifndef __ASSEMBLY__ enum VM_CACHE_OPS { - ickill, - dckill, - l2kill, - dccleaninva, - icinva, - idsync, - fetch_cfg + vm_ickill, + vm_dckill, + vm_l2kill, + vm_dccleaninva, + vm_icinva, + vm_idsync, + vm_fetch_cfg }; enum VM_INT_OPS { - nop, - globen, - globdis, - locen, - locdis, - affinity, - get, - peek, - status, - post, - clear + vm_nop, + vm_globen, + vm_globdis, + vm_locen, + vm_locdis, + vm_affinity, + vm_get, + vm_peek, + vm_status, + vm_post, + vm_clear }; extern void _K_VM_event_vector(void); @@ -98,65 +98,65 @@ long __vmvpid(void); static inline long __vmcache_ickill(void) { - return __vmcache(ickill, 0, 0); + return __vmcache(vm_ickill, 0, 0); } static inline long __vmcache_dckill(void) { - return __vmcache(dckill, 0, 0); + return __vmcache(vm_dckill, 0, 0); } static inline long __vmcache_l2kill(void) { - return __vmcache(l2kill, 0, 0); + return __vmcache(vm_l2kill, 0, 0); } static inline long __vmcache_dccleaninva(unsigned long addr, unsigned long len) { - return __vmcache(dccleaninva, addr, len); + return __vmcache(vm_dccleaninva, addr, len); } static inline long __vmcache_icinva(unsigned long addr, unsigned long len) { - return __vmcache(icinva, addr, len); + return __vmcache(vm_icinva, addr, len); } static inline long __vmcache_idsync(unsigned long addr, unsigned long len) { - return __vmcache(idsync, addr, len); + return __vmcache(vm_idsync, addr, len); } static inline long __vmcache_fetch_cfg(unsigned long val) { - return __vmcache(fetch_cfg, val, 0); + return __vmcache(vm_fetch_cfg, val, 0); } /* interrupt operations */ static inline long __vmintop_nop(void) { - return __vmintop(nop, 0, 0, 0, 0); + return __vmintop(vm_nop, 0, 0, 0, 0); } static inline long __vmintop_globen(long i) { - return __vmintop(globen, i, 0, 0, 0); + return __vmintop(vm_globen, i, 0, 0, 0); } static inline long __vmintop_globdis(long i) { - return __vmintop(globdis, i, 0, 0, 0); + return __vmintop(vm_globdis, i, 0, 0, 0); } static inline long __vmintop_locen(long i) { - return __vmintop(locen, i, 0, 0, 0); + return __vmintop(vm_locen, i, 0, 0, 0); } static inline long __vmintop_locdis(long i) { - return __vmintop(locdis, i, 0, 0, 0); + return __vmintop(vm_locdis, i, 0, 0, 0); } static inline long __vmintop_affinity(long i, long cpu) @@ -166,27 +166,27 @@ static inline long __vmintop_affinity(long i, long cpu) static inline long __vmintop_get(void) { - return __vmintop(get, 0, 0, 0, 0); + return __vmintop(vm_get, 0, 0, 0, 0); } static inline long __vmintop_peek(void) { - return __vmintop(peek, 0, 0, 0, 0); + return __vmintop(vm_peek, 0, 0, 0, 0); } static inline long __vmintop_status(long i) { - return __vmintop(status, i, 0, 0, 0); + return __vmintop(vm_status, i, 0, 0, 0); } static inline long __vmintop_post(long i) { - return __vmintop(post, i, 0, 0, 0); + return __vmintop(vm_post, i, 0, 0, 0); } static inline long __vmintop_clear(long i) { - return __vmintop(clear, i, 0, 0, 0); + return __vmintop(vm_clear, i, 0, 0, 0); } #else /* Only assembly code should reference these */ -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() in "hexagon_vm.h" 2013-11-25 2:40 ` [PATCH 1/2] " Chen Gang @ 2013-11-25 2:41 ` Chen Gang 2013-11-28 8:51 ` [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members " Chen Gang 2013-11-26 4:36 ` [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" " Chen Gang 1 sibling, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-25 2:41 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org All __vmintop_*() use __vmintop(*, ...), so __vmintop_affinity() need use __vmintop(vm_affinity, ...). Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/hexagon_vm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/hexagon/include/asm/hexagon_vm.h b/arch/hexagon/include/asm/hexagon_vm.h index e1e0470..3ea99c1 100644 --- a/arch/hexagon/include/asm/hexagon_vm.h +++ b/arch/hexagon/include/asm/hexagon_vm.h @@ -161,7 +161,7 @@ static inline long __vmintop_locdis(long i) static inline long __vmintop_affinity(long i, long cpu) { - return __vmintop(locdis, i, cpu, 0, 0); + return __vmintop(vm_affinity, i, cpu, 0, 0); } static inline long __vmintop_get(void) -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members in "hexagon_vm.h" 2013-11-25 2:41 ` [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() " Chen Gang @ 2013-11-28 8:51 ` Chen Gang 2013-12-06 18:22 ` rkuo 0 siblings, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-28 8:51 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org Append "hvmc_" or "hvmi_" to all related enum members (which are too common to make conflict with another sub-systems). The related error with allmodconfig: CC [M] drivers/md/raid1.o drivers/md/raid1.c:1440:13: error: 'status' redeclared as different kind of symbol arch/hexagon/include/asm/hexagon_vm.h:76:2: note: previous definition of 'status' was here Also use 'affinity' instead of 'locdis' for __vmintop_affinity(). Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/hexagon_vm.h | 72 ++++++++++++++++---------------- 1 files changed, 36 insertions(+), 36 deletions(-) diff --git a/arch/hexagon/include/asm/hexagon_vm.h b/arch/hexagon/include/asm/hexagon_vm.h index 67bb6d6..1f6918b 100644 --- a/arch/hexagon/include/asm/hexagon_vm.h +++ b/arch/hexagon/include/asm/hexagon_vm.h @@ -55,27 +55,27 @@ #ifndef __ASSEMBLY__ enum VM_CACHE_OPS { - ickill, - dckill, - l2kill, - dccleaninva, - icinva, - idsync, - fetch_cfg + hvmc_ickill, + hvmc_dckill, + hvmc_l2kill, + hvmc_dccleaninva, + hvmc_icinva, + hvmc_idsync, + hvmc_fetch_cfg }; enum VM_INT_OPS { - nop, - globen, - globdis, - locen, - locdis, - affinity, - get, - peek, - status, - post, - clear + hvmi_nop, + hvmi_globen, + hvmi_globdis, + hvmi_locen, + hvmi_locdis, + hvmi_affinity, + hvmi_get, + hvmi_peek, + hvmi_status, + hvmi_post, + hvmi_clear }; extern void _K_VM_event_vector(void); @@ -98,95 +98,95 @@ long __vmvpid(void); static inline long __vmcache_ickill(void) { - return __vmcache(ickill, 0, 0); + return __vmcache(hvmc_ickill, 0, 0); } static inline long __vmcache_dckill(void) { - return __vmcache(dckill, 0, 0); + return __vmcache(hvmc_dckill, 0, 0); } static inline long __vmcache_l2kill(void) { - return __vmcache(l2kill, 0, 0); + return __vmcache(hvmc_l2kill, 0, 0); } static inline long __vmcache_dccleaninva(unsigned long addr, unsigned long len) { - return __vmcache(dccleaninva, addr, len); + return __vmcache(hvmc_dccleaninva, addr, len); } static inline long __vmcache_icinva(unsigned long addr, unsigned long len) { - return __vmcache(icinva, addr, len); + return __vmcache(hvmc_icinva, addr, len); } static inline long __vmcache_idsync(unsigned long addr, unsigned long len) { - return __vmcache(idsync, addr, len); + return __vmcache(hvmc_idsync, addr, len); } static inline long __vmcache_fetch_cfg(unsigned long val) { - return __vmcache(fetch_cfg, val, 0); + return __vmcache(hvmc_fetch_cfg, val, 0); } /* interrupt operations */ static inline long __vmintop_nop(void) { - return __vmintop(nop, 0, 0, 0, 0); + return __vmintop(hvmi_nop, 0, 0, 0, 0); } static inline long __vmintop_globen(long i) { - return __vmintop(globen, i, 0, 0, 0); + return __vmintop(hvmi_globen, i, 0, 0, 0); } static inline long __vmintop_globdis(long i) { - return __vmintop(globdis, i, 0, 0, 0); + return __vmintop(hvmi_globdis, i, 0, 0, 0); } static inline long __vmintop_locen(long i) { - return __vmintop(locen, i, 0, 0, 0); + return __vmintop(hvmi_locen, i, 0, 0, 0); } static inline long __vmintop_locdis(long i) { - return __vmintop(locdis, i, 0, 0, 0); + return __vmintop(hvmi_locdis, i, 0, 0, 0); } static inline long __vmintop_affinity(long i, long cpu) { - return __vmintop(locdis, i, cpu, 0, 0); + return __vmintop(hvmi_affinity, i, cpu, 0, 0); } static inline long __vmintop_get(void) { - return __vmintop(get, 0, 0, 0, 0); + return __vmintop(hvmi_get, 0, 0, 0, 0); } static inline long __vmintop_peek(void) { - return __vmintop(peek, 0, 0, 0, 0); + return __vmintop(hvmi_peek, 0, 0, 0, 0); } static inline long __vmintop_status(long i) { - return __vmintop(status, i, 0, 0, 0); + return __vmintop(hvmi_status, i, 0, 0, 0); } static inline long __vmintop_post(long i) { - return __vmintop(post, i, 0, 0, 0); + return __vmintop(hvmi_post, i, 0, 0, 0); } static inline long __vmintop_clear(long i) { - return __vmintop(clear, i, 0, 0, 0); + return __vmintop(hvmi_clear, i, 0, 0, 0); } #else /* Only assembly code should reference these */ -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members in "hexagon_vm.h" 2013-11-28 8:51 ` [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members " Chen Gang @ 2013-12-06 18:22 ` rkuo 0 siblings, 0 replies; 14+ messages in thread From: rkuo @ 2013-12-06 18:22 UTC (permalink / raw) To: Chen Gang; +Cc: linux-hexagon, linux-kernel@vger.kernel.org On Thu, Nov 28, 2013 at 04:51:45PM +0800, Chen Gang wrote: > Append "hvmc_" or "hvmi_" to all related enum members (which are too > common to make conflict with another sub-systems). The related error > with allmodconfig: > > CC [M] drivers/md/raid1.o > drivers/md/raid1.c:1440:13: error: 'status' redeclared as different kind of symbol > arch/hexagon/include/asm/hexagon_vm.h:76:2: note: previous definition of 'status' was here > > Also use 'affinity' instead of 'locdis' for __vmintop_affinity(). > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/include/asm/hexagon_vm.h | 72 ++++++++++++++++---------------- > 1 files changed, 36 insertions(+), 36 deletions(-) > Thanks for catching the affinity typo too. Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" 2013-11-25 2:40 ` [PATCH 1/2] " Chen Gang 2013-11-25 2:41 ` [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() " Chen Gang @ 2013-11-26 4:36 ` Chen Gang 2013-11-27 5:28 ` [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ Chen Gang 1 sibling, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-26 4:36 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org On 11/25/2013 10:40 AM, Chen Gang wrote: > Append "vm_" to all enum members (which are too common to make conflict > with another sub-systems). The related error with allmodconfig: > > CC [M] drivers/md/raid1.o > drivers/md/raid1.c:1440:13: error: 'status' redeclared as different kind of symbol > arch/hexagon/include/asm/hexagon_vm.h:76:2: note: previous definition of 'status' was here > Oh, sorry, The new prefix "vm_" is still conflict with others. One case is below (bottom of this mail) I will use "hvmc_" for VM_CACHE_OPS and "hvmi_" for VM_INT_OPS instead of. If get no rejections within 1 day, I will send patch v2 for it. And also I will merge the related 2 patches together (although they are for 2 issues). > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/include/asm/hexagon_vm.h | 70 ++++++++++++++++---------------- > 1 files changed, 35 insertions(+), 35 deletions(-) > > diff --git a/arch/hexagon/include/asm/hexagon_vm.h b/arch/hexagon/include/asm/hexagon_vm.h > index 67bb6d6..e1e0470 100644 > --- a/arch/hexagon/include/asm/hexagon_vm.h > +++ b/arch/hexagon/include/asm/hexagon_vm.h > @@ -55,27 +55,27 @@ > #ifndef __ASSEMBLY__ > > enum VM_CACHE_OPS { > - ickill, > - dckill, > - l2kill, > - dccleaninva, > - icinva, > - idsync, > - fetch_cfg > + vm_ickill, > + vm_dckill, > + vm_l2kill, > + vm_dccleaninva, > + vm_icinva, > + vm_idsync, > + vm_fetch_cfg > }; > > enum VM_INT_OPS { > - nop, > - globen, > - globdis, > - locen, > - locdis, > - affinity, > - get, > - peek, > - status, > - post, > - clear > + vm_nop, > + vm_globen, > + vm_globdis, > + vm_locen, > + vm_locdis, > + vm_affinity, > + vm_get, The new prefix "vm_" for "get" is still conflict with others: CC [M] drivers/virtio/virtio_mmio.o drivers/virtio/virtio_mmio.c:170:13: error: 'vm_get' redeclared as different kind of symbol arch/hexagon/include/asm/hexagon_vm.h:74:2: note: previous definition of 'vm_get' was here Thanks. -- Chen Gang ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ 2013-11-26 4:36 ` [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" " Chen Gang @ 2013-11-27 5:28 ` Chen Gang 2013-12-06 18:21 ` rkuo 0 siblings, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-27 5:28 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org Define dummy '__init' instead of include "linux/init.h" if !__KERNEL__, or can not pass checking. The related error (with allmodconfig under hexagon): CHECK include/asm (34 files) usr/include/asm/setup.h:22: included file 'linux/init.h' is not exported Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/uapi/asm/setup.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/hexagon/include/uapi/asm/setup.h b/arch/hexagon/include/uapi/asm/setup.h index e48285e4a..7e3952d 100644 --- a/arch/hexagon/include/uapi/asm/setup.h +++ b/arch/hexagon/include/uapi/asm/setup.h @@ -19,7 +19,12 @@ #ifndef _ASM_SETUP_H #define _ASM_SETUP_H +#ifdef __KERNEL__ #include <linux/init.h> +#else +#define __init +#endif + #include <asm-generic/setup.h> extern char external_cmdline_buffer; -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ 2013-11-27 5:28 ` [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ Chen Gang @ 2013-12-06 18:21 ` rkuo 0 siblings, 0 replies; 14+ messages in thread From: rkuo @ 2013-12-06 18:21 UTC (permalink / raw) To: Chen Gang; +Cc: linux-hexagon, linux-kernel@vger.kernel.org On Wed, Nov 27, 2013 at 01:28:36PM +0800, Chen Gang wrote: > Define dummy '__init' instead of include "linux/init.h" if !__KERNEL__, > or can not pass checking. The related error (with allmodconfig under > hexagon): > > CHECK include/asm (34 files) > usr/include/asm/setup.h:22: included file 'linux/init.h' is not exported > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/include/uapi/asm/setup.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" 2013-11-25 1:19 ` rkuo 2013-11-25 2:39 ` [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" Chen Gang @ 2013-11-26 4:07 ` Chen Gang 2013-11-26 4:09 ` [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild Chen Gang 2013-12-06 18:19 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" rkuo 1 sibling, 2 replies; 14+ messages in thread From: Chen Gang @ 2013-11-26 4:07 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon Need dumy mmiowb(), or can not pass compiling, the related error with allmodconfig: CC [M] drivers/mmc/host/sdhci.o drivers/mmc/host/sdhci.c: In function 'sdhci_request': drivers/mmc/host/sdhci.c:1409:2: error: implicit declaration of function 'mmiowb' [-Werror=implicit-function-declaration] Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/io.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h index 1b7698e..7029899 100644 --- a/arch/hexagon/include/asm/io.h +++ b/arch/hexagon/include/asm/io.h @@ -189,6 +189,8 @@ static inline void writel(u32 data, volatile void __iomem *addr) #define writew_relaxed __raw_writew #define writel_relaxed __raw_writel +#define mmiowb() + /* * Need an mtype somewhere in here, for cache type deals? * This is probably too long for an inline. -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild 2013-11-26 4:07 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" Chen Gang @ 2013-11-26 4:09 ` Chen Gang 2013-12-06 18:20 ` rkuo 2013-12-06 18:19 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" rkuo 1 sibling, 1 reply; 14+ messages in thread From: Chen Gang @ 2013-11-26 4:09 UTC (permalink / raw) To: rkuo; +Cc: linux-hexagon, Peter Zijlstra, Ingo Molnar Add "serial.h" in Kbuild, or can not pass compiling with allmodconfig, the related error: CC [M] drivers/staging/speakup/speakup_acntpc.o In file included from drivers/staging/speakup/speakup_acntpc.c:33:0: drivers/staging/speakup/serialio.h:7:24: fatal error: asm/serial.h: No such file or directory Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- arch/hexagon/include/asm/Kbuild | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/hexagon/include/asm/Kbuild b/arch/hexagon/include/asm/Kbuild index 424e28e..0852230 100644 --- a/arch/hexagon/include/asm/Kbuild +++ b/arch/hexagon/include/asm/Kbuild @@ -38,6 +38,7 @@ generic-y += scatterlist.h generic-y += sections.h generic-y += segment.h generic-y += sembuf.h +generic-y += serial.h generic-y += shmbuf.h generic-y += shmparam.h generic-y += siginfo.h -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild 2013-11-26 4:09 ` [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild Chen Gang @ 2013-12-06 18:20 ` rkuo 0 siblings, 0 replies; 14+ messages in thread From: rkuo @ 2013-12-06 18:20 UTC (permalink / raw) To: Chen Gang; +Cc: linux-hexagon, Peter Zijlstra, Ingo Molnar On Tue, Nov 26, 2013 at 12:09:43PM +0800, Chen Gang wrote: > Add "serial.h" in Kbuild, or can not pass compiling with allmodconfig, > the related error: > > CC [M] drivers/staging/speakup/speakup_acntpc.o > In file included from drivers/staging/speakup/speakup_acntpc.c:33:0: > drivers/staging/speakup/serialio.h:7:24: fatal error: asm/serial.h: No such file or directory > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/include/asm/Kbuild | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" 2013-11-26 4:07 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" Chen Gang 2013-11-26 4:09 ` [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild Chen Gang @ 2013-12-06 18:19 ` rkuo 1 sibling, 0 replies; 14+ messages in thread From: rkuo @ 2013-12-06 18:19 UTC (permalink / raw) To: Chen Gang; +Cc: linux-hexagon On Tue, Nov 26, 2013 at 12:07:40PM +0800, Chen Gang wrote: > Need dumy mmiowb(), or can not pass compiling, the related error with > allmodconfig: > > CC [M] drivers/mmc/host/sdhci.o > drivers/mmc/host/sdhci.c: In function 'sdhci_request': > drivers/mmc/host/sdhci.c:1409:2: error: implicit declaration of function 'mmiowb' [-Werror=implicit-function-declaration] > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/include/asm/io.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > Acked-by: Richard Kuo <rkuo@codeaurora.org> -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-12-06 18:22 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-19 4:57 [PATCH] arch: hexagon: Kconfig: add HAVE_DMA_ATTR in Kconfig and remove "linux/dma-mapping.h" from "asm/dma-mapping.h" Chen Gang 2013-11-25 1:19 ` rkuo 2013-11-25 2:39 ` [PATCH 0/2] arch: hexagon: include: asm: add prefix "vm_" for all enum members in "hexagon_vm.h" Chen Gang 2013-11-25 2:40 ` [PATCH 1/2] " Chen Gang 2013-11-25 2:41 ` [PATCH 2/2] arch: hexagon: include: asm: use 'affinity' instead of 'locdis' for __vmintop_affinity() " Chen Gang 2013-11-28 8:51 ` [PATCH v2] arch: hexagon: include: asm: add prefix "hvm[ci]_" for all enum members " Chen Gang 2013-12-06 18:22 ` rkuo 2013-11-26 4:36 ` [PATCH 1/2] arch: hexagon: include: asm: add prefix "vm_" " Chen Gang 2013-11-27 5:28 ` [PATCH] arch: hexagon: include: uapi: asm: setup.h add swith macro __KERNEL__ Chen Gang 2013-12-06 18:21 ` rkuo 2013-11-26 4:07 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" Chen Gang 2013-11-26 4:09 ` [PATCH] arch: hexagon: include: asm: Kbuild: add generic "serial.h" in Kbuild Chen Gang 2013-12-06 18:20 ` rkuo 2013-12-06 18:19 ` [PATCH] arch: hexagon: include: asm: add generic macro 'mmiowb' in "io.h" rkuo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).