From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly Date: Thu, 14 Aug 2014 20:04:18 +0200 Message-ID: <20140814180418.GA20777@linux-mips.org> References: <53ECE9DD.80004@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <53ECE9DD.80004@gmail.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: List-subscribe: List-owner: List-post: List-archive: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chen Gang Cc: Arnd Bergmann , akpm@linux-foundation.org, rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@synopsys.com, Geert Uytterhoeven , Jean Delvare , linux@arm.linux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com, msalter@redhat.com, a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com, rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com, takata@linux-m32r.org, james.hogan@imgtec.com, Michal Simek , yasutake.koichi@jp.panasonic.com, jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de, Benjamin Herrenschmidt , paulus@samba.org, mpe@ellerman.id.au, Mart On Fri, Aug 15, 2014 at 12:54:53AM +0800, Chen Gang wrote: > Normal architectures: > > - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc > > - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300, > score, unicore32, x86 > > - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh Nak for MIPS. On MIPS Kconfig already always sets one of CPU_BIG_ENDIAN and CPU_LITTLE_ENDIAN depending on platforms and where both endianess are supported by a platform, user choice: config FOO bool "foo" select SYS_SUPPORTS_LITTLE_ENDIAN config FOO bool "foo" select SYS_SUPPORTS_BIG_ENDIAN select SYS_SUPPORTS_LITTLE_ENDIAN [...] choice prompt "Endianess selection" help Some MIPS machines can be configured for either little or big endian byte order. These modes require different kernels and a different Linux distribution. In general there is one preferred byteorder for a particular system but some systems are just as commonly used in the one or the other endianness. config CPU_BIG_ENDIAN bool "Big endian" depends on SYS_SUPPORTS_BIG_ENDIAN config CPU_LITTLE_ENDIAN bool "Little endian" depends on SYS_SUPPORTS_LITTLE_ENDIAN help endchoice So I think you can just drop the MIPS segment from your patch. Ralf