From: Mike Frysinger <vapier@gentoo.org>
To: rkuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org
Subject: Re: [PATCH] Revert "Hexagon: fix signal.c compile error"
Date: Thu, 23 Apr 2015 23:59:25 -0400 [thread overview]
Message-ID: <20150424035925.GU12496@vapier> (raw)
In-Reply-To: <20150423204036.GA5404@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
On 23 Apr 2015 15:40, rkuo wrote:
> On Wed, Apr 22, 2015 at 09:28:04PM -0400, Mike Frysinger wrote:
> > This reverts commit f3f601c1d2728f02544cfd143eaa82e5398b3e9b.
> >
> > UAPI headers cannot use "uapi/" in their paths by design -- when they're
> > installed, they do not have the uapi/ prefix. Otherwise doing so breaks
> > userland badly.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > arch/hexagon/include/uapi/asm/signal.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/hexagon/include/uapi/asm/signal.h b/arch/hexagon/include/uapi/asm/signal.h
> > index 98106e5..24b9988 100644
> > --- a/arch/hexagon/include/uapi/asm/signal.h
> > +++ b/arch/hexagon/include/uapi/asm/signal.h
> > @@ -19,8 +19,6 @@
> > #ifndef _ASM_SIGNAL_H
> > #define _ASM_SIGNAL_H
> >
> > -#include <uapi/asm/registers.h>
> > -
> > extern unsigned long __rt_sigtramp_template[2];
> >
> > void do_signal(struct pt_regs *regs);
> > --
> > 2.3.5
> >
>
> I'll need to actually fix the thing the original commit was trying to fix,
> but I can follow up with another patch.
i was throwing the revert up as a straw man of sorts. i've never used hexagon
myself, so if someone wants to put together a better fix, then by all means.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-04-24 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 1:28 [PATCH] Revert "Hexagon: fix signal.c compile error" Mike Frysinger
2015-04-23 20:40 ` rkuo
2015-04-24 3:59 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424035925.GU12496@vapier \
--to=vapier@gentoo.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).