From: Guenter Roeck <linux@roeck-us.net>
To: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: hexagon: Use raw_copy_to_user
Date: Fri, 2 Jun 2017 06:03:53 -0700 [thread overview]
Message-ID: <20170602130353.GA11696@roeck-us.net> (raw)
In-Reply-To: <1493783568-9887-1-git-send-email-linux@roeck-us.net>
ping ....
On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
>
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> implicit declaration of function '__copy_to_user_hexagon'
>
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> arch/hexagon/mm/uaccess.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> index ec90afdb3ad0..c599eb126c9e 100644
> --- a/arch/hexagon/mm/uaccess.c
> +++ b/arch/hexagon/mm/uaccess.c
> @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> long uncleared;
>
> while (count > PAGE_SIZE) {
> - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> - PAGE_SIZE);
> + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> if (uncleared)
> return count - (PAGE_SIZE - uncleared);
> count -= PAGE_SIZE;
> dest += PAGE_SIZE;
> }
> if (count)
> - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> + count = raw_copy_to_user(dest, &empty_zero_page, count);
>
> return count;
> }
next prev parent reply other threads:[~2017-06-02 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 3:52 [PATCH] hexagon: Use raw_copy_to_user Guenter Roeck
2017-05-03 5:17 ` Al Viro
2017-06-02 13:03 ` Guenter Roeck [this message]
2017-06-02 21:33 ` Richard Kuo
2017-06-02 22:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602130353.GA11696@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).