From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH 00/50] Add log level to show_stack() Date: Tue, 12 Nov 2019 13:57:04 +0900 Message-ID: <20191112045704.GA138013@google.com> References: <20191106030542.868541-1-dima@arista.com> <20191106083538.z5nlpuf64cigxigh@pathway.suse.cz> <20191108103719.GB175344@google.com> <20191108130447.h3wfgo4efjkto56f@pathway.suse.cz> <20191111012336.GA85185@google.com> <20191111091207.u3lrd6cmumnx4czr@pathway.suse.cz> <20191112044447.GA121272@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=60PhTaCofcpqzy2dewe8/r3dT6ewp75zDjdUc8zTdCY=; b=HyxyR/+ZXPGCC7 vbbHogYUB6tbIGt42j0Gq7UtwcfW+Y3oiqws0D/fNMAsD7bYLCSAozzTS33nkatWXGhmZfx4KgGKc p8mFHFP85PjLVjD68jxZYUPN4e9ggcxSVml8cLR6IFGYyfrVEpz+DoEdOU+vvo817xvVyK2V3jvuG k3x5LrNymJX6nic/KeWuGOdScs3gFOghVxqE+PpiOqWfHyWsmVDxyqurSCC383hY5wMTVDn6x6p32 PgC8qu9zjGp9Vl9rEKT7g9oFnpb3ZAWSplxLJVdyUfagX1RvbLoSMFwOYiwcGeXabfcTay9GoDfwJ PZPNlSlWQ6p/pYJy/Tig==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tE21poLWpjs1GduZLj+PgABwuxQTljOZlec7LOXTsTQ=; b=AI85TZuxJFzpojKZJlquzPJ/5YvDFz8JEdaGZ7N9Bmfov5X7GyMy3TfvkUyQANtqKe uWjtNNrB596OMU00c6+qct2nMEsGN4W/ajrsVlovtW2vJG2fjivE6vkHc9d5Fc8S37eB 0VpD+e7K/Ht0coC/nAVEUQFQLhXtyB4aw6jKMKF9ff8HzhVOsLQ13K9MvUH4nh17A3b8 X0IG+zvP4YjZB9qcfjrPIBuuKfgEibO6DzaNR3cG8TZwz73XhoRwn86VlJzYDpndT6LU MtpcwxBGTg4+qOqVF/y48uFNpA2bAo7xyKsOHk/v6yI7+ZG1IGpxyK0r3md+ToHLMdrK mWjA== Content-Disposition: inline In-Reply-To: <20191112044447.GA121272@google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org To: Petr Mladek Cc: Juri Lelli , Sergey Senozhatsky , linux-sh@vger.kernel.org, Catalin Marinas , Ben Segall , Guo Ren , Pavel Machek , Vincent Guittot , Paul Burton , Dmitry Safonov , Michael Ellerman , Geert Uytterhoeven , Mel Gorman , Jiri Slaby , Matt Turner , uclinux-h8-devel@lists.sourceforge.jp, Len Brown , linux-pm@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Thomas Gleixner , Dietmar Eggemann , Richard Henderson , Greg Kroah-Hartman On (19/11/12 13:44), Sergey Senozhatsky wrote: [..] > > But yes, this per-code-section loglevel is problematic. The feedback > > against the patchset shows that people want it also the other way. > > I mean to keep pr_debug() as pr_debug(). > > Hmm. Right. > > > A solution might be to use the per-code-section loglevel only instead > > of some special loglevel. > > So maybe we can "overwrite" only KERN_DEFAULT loglevels? LOGLEVEL_DEFAULT, LOGLEVEL_NOTICE, LOGLEVEL_INFO? So we can downgrade some messages (log_store() only) or promote some messages. DEBUG perhaps should stay debug. > We certainly should not mess with SCHED or with anything in between > EMERG and ERR. [EMERG, WARN] -ss