From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Brian Cain <bcain@codeaurora.org>,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
Tuowen Zhao <ztuowen@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error
Date: Mon, 9 Dec 2019 16:40:39 +0200 [thread overview]
Message-ID: <20191209144039.GI32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191204133328.18668-1-linux@roeck-us.net>
On Wed, Dec 04, 2019 at 05:33:28AM -0800, Guenter Roeck wrote:
> ioremap_uc is now mandatory.
>
> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
Thanks for a fix!
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
> Cc: Tuowen Zhao <ztuowen@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/hexagon/include/asm/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> index 539e3efcf39c..39e5605c5d42 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>
> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
> #define ioremap_nocache ioremap
> -
> +#define ioremap_uc ioremap
>
> #define __raw_writel writel
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-12-09 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 13:33 [PATCH] hexagon: io: Define ioremap_uc to fix build error Guenter Roeck
2019-12-09 14:40 ` Andy Shevchenko [this message]
2019-12-10 8:09 ` Geert Uytterhoeven
2019-12-10 8:23 ` Guenter Roeck
2019-12-10 8:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209144039.GI32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bcain@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcgrof@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ztuowen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).