Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE

Rob Herring
2021-04-08T19:04:08Z

On Tue, Apr 06, 2021 at 10:38:36AM -0700, Daniel Walker wrote:
> On Fri, Apr 02, 2021 at 03:18:21PM +0000, Christophe Leroy wrote:
> > -config CMDLINE_BOOL
> > - bool "Built-in kernel command line"
> > - help
> > - For most systems, it is firmware or second stage bootloader that
> > - by default specifies the kernel command line options. However,
> > - it might be necessary or advantageous to either override the
> > - default kernel command line or add a few extra options to it.
> > - For such cases, this option allows you to hardcode your own
> > - command line options directly into the kernel. For that, you
> > - should choose 'Y' here, and fill in the extra boot arguments
> > - in CONFIG_CMDLINE.
> > -
> > - The built-in options will be concatenated to the default command
> > - line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default
> > - command line will be ignored and replaced by the built-in string.
> > -
> > - Most MIPS systems will normally expect 'N' here and rely upon
> > - the command line from the firmware or the second-stage bootloader.
> > -
>
>
> See how you complained that I have CMDLINE_BOOL in my changed, and you think it
> shouldn't exist.
>
> Yet here mips has it, and you just deleted it with no feature parity in your
> changes for this.

AFAICT, CMDLINE_BOOL equates to a non-empty or empty CONFIG_CMDLINE. You
seem to need it just because you have CMDLINE_PREPEND and
CMDLINE_APPEND. If that's not it, what feature is missing? CMDLINE_BOOL
is not a feature, but an implementation detail.

Rob