* [PATCH] hexagon: move from strlcpy with unused retval to strscpy
@ 2022-08-18 20:59 Wolfram Sang
2022-08-20 17:43 ` Brian Cain
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2022-08-18 20:59 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Brian Cain, linux-hexagon
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/hexagon/kernel/setup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/hexagon/kernel/setup.c b/arch/hexagon/kernel/setup.c
index 1880d9beaf2b..621674e86232 100644
--- a/arch/hexagon/kernel/setup.c
+++ b/arch/hexagon/kernel/setup.c
@@ -66,9 +66,9 @@ void __init setup_arch(char **cmdline_p)
on_simulator = 0;
if (p[0] != '\0')
- strlcpy(boot_command_line, p, COMMAND_LINE_SIZE);
+ strscpy(boot_command_line, p, COMMAND_LINE_SIZE);
else
- strlcpy(boot_command_line, default_command_line,
+ strscpy(boot_command_line, default_command_line,
COMMAND_LINE_SIZE);
/*
@@ -76,7 +76,7 @@ void __init setup_arch(char **cmdline_p)
* are both picked up by the init code. If no reason to
* make them different, pass the same pointer back.
*/
- strlcpy(cmd_line, boot_command_line, COMMAND_LINE_SIZE);
+ strscpy(cmd_line, boot_command_line, COMMAND_LINE_SIZE);
*cmdline_p = cmd_line;
parse_early_param();
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] hexagon: move from strlcpy with unused retval to strscpy
2022-08-18 20:59 [PATCH] hexagon: move from strlcpy with unused retval to strscpy Wolfram Sang
@ 2022-08-20 17:43 ` Brian Cain
0 siblings, 0 replies; 2+ messages in thread
From: Brian Cain @ 2022-08-20 17:43 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel@vger.kernel.org; +Cc: linux-hexagon@vger.kernel.org
> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
...
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
Acked-by: Brian Cain <bcain@quicinc.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-20 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-18 20:59 [PATCH] hexagon: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-20 17:43 ` Brian Cain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).