From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "wuqiang.matt" <wuqiang.matt@bytedance.com>
Cc: vgupta@kernel.org, bcain@quicinc.com, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi, shorne@gmail.com,
geert@linux-m68k.org, andi.shyti@linux.intel.com,
mingo@kernel.org, palmer@rivosinc.com, andrzej.hajda@intel.com,
arnd@arndb.de, peterz@infradead.orgm,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, mattwu@163.com,
linux@roeck-us.ne
Subject: Re: [PATCH v2 3/4] locking/atomic: openrisc: arch_cmpxchg[64]_local undefined
Date: Wed, 8 Nov 2023 10:03:22 +0900 [thread overview]
Message-ID: <20231108100322.06cc58b4fd142ccbb8d3751e@kernel.org> (raw)
In-Reply-To: <20231104091615.4884-4-wuqiang.matt@bytedance.com>
On Sat, 4 Nov 2023 17:16:14 +0800
"wuqiang.matt" <wuqiang.matt@bytedance.com> wrote:
> For architectures that support native cmpxchg, we'd like to
> implement arch_cmpxchg[64]_local with the native variants of
> supported data size. If not, the generci_cmpxchg[64]_local
> will be used.
Looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com>
> ---
> arch/openrisc/include/asm/cmpxchg.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/openrisc/include/asm/cmpxchg.h b/arch/openrisc/include/asm/cmpxchg.h
> index 8ee151c072e4..f1ffe8b6f5ef 100644
> --- a/arch/openrisc/include/asm/cmpxchg.h
> +++ b/arch/openrisc/include/asm/cmpxchg.h
> @@ -139,6 +139,12 @@ static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old,
> (unsigned long)(n), \
> sizeof(*(ptr))); \
> })
> +#define arch_cmpxchg_local arch_cmpxchg
> +
> +/* always make arch_cmpxchg64_local available for openrisc */
> +#include <asm-generic/cmpxchg-local.h>
> +
> +#define arch_cmpxchg64_local(ptr, o, n) __generic_cmpxchg64_local((ptr), (o), (n))
>
> /*
> * This function doesn't exist, so you'll get a linker error if
> --
> 2.40.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-11-08 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 9:16 [PATCH v2 0/4] locking/atomic: arch_cmpxchg[64]_local undefined wuqiang.matt
2023-11-04 9:16 ` [PATCH v2 1/4] locking/atomic: arc: data size checking in arch_cmpxchg wuqiang.matt
2023-11-08 1:02 ` Masami Hiramatsu
2023-11-04 9:16 ` [PATCH v2 2/4] locking/atomic: arc: arch_cmpxchg[64]_local undefined wuqiang.matt
2023-11-08 1:02 ` Masami Hiramatsu
2023-11-04 9:16 ` [PATCH v2 3/4] locking/atomic: openrisc: " wuqiang.matt
2023-11-08 1:03 ` Masami Hiramatsu [this message]
2023-11-04 9:16 ` [PATCH v2 4/4] locking/atomic: hexagon: " wuqiang.matt
2023-11-08 1:04 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108100322.06cc58b4fd142ccbb8d3751e@kernel.org \
--to=mhiramat@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=geert@linux-m68k.org \
--cc=jonas@southpole.se \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.ne \
--cc=mattwu@163.com \
--cc=mingo@kernel.org \
--cc=palmer@rivosinc.com \
--cc=peterz@infradead.orgm \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=vgupta@kernel.org \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).