linux-hexagon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hexagon: vdso: Fix build failure
@ 2024-09-23 13:52 Guenter Roeck
  2024-09-23 15:14 ` Brian Cain
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2024-09-23 13:52 UTC (permalink / raw)
  To: Brian Cain; +Cc: linux-hexagon, linux-kernel, Guenter Roeck, Linus Torvalds

Hexagon images fail to build with the following error.

arch/hexagon/kernel/vdso.c:57:3: error: use of undeclared identifier 'name'
                name = "[vdso]",
                ^

Add the missing '.' to fix the problem.

Fixes: 497258dfafcc ("mm: remove legacy install_special_mapping() code")
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/hexagon/kernel/vdso.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/hexagon/kernel/vdso.c b/arch/hexagon/kernel/vdso.c
index 6fd27ff1df73..8119084dc519 100644
--- a/arch/hexagon/kernel/vdso.c
+++ b/arch/hexagon/kernel/vdso.c
@@ -54,7 +54,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
 	struct vm_area_struct *vma;
 	struct mm_struct *mm = current->mm;
 	static struct vm_special_mapping vdso_mapping = {
-		name = "[vdso]",
+		.name = "[vdso]",
 	};
 
 	if (mmap_write_lock_killable(mm))
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] hexagon: vdso: Fix build failure
  2024-09-23 13:52 [PATCH] hexagon: vdso: Fix build failure Guenter Roeck
@ 2024-09-23 15:14 ` Brian Cain
  0 siblings, 0 replies; 2+ messages in thread
From: Brian Cain @ 2024-09-23 15:14 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds, Sid Manning, Nathan Chancellor

> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Monday, September 23, 2024 8:53 AM
> To: Brian Cain <bcain@quicinc.com>
> Cc: linux-hexagon@vger.kernel.org; linux-kernel@vger.kernel.org; Guenter
> Roeck <linux@roeck-us.net>; Linus Torvalds <torvalds@linux-foundation.org>
> Subject: [PATCH] hexagon: vdso: Fix build failure
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> Hexagon images fail to build with the following error.
> 
> arch/hexagon/kernel/vdso.c:57:3: error: use of undeclared identifier 'name'
>                 name = "[vdso]",
>                 ^
> 
> Add the missing '.' to fix the problem.
> 
> Fixes: 497258dfafcc ("mm: remove legacy install_special_mapping() code")
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Reviewed-by: Brian Cain <bcain@quicinc.com>

>  arch/hexagon/kernel/vdso.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/hexagon/kernel/vdso.c b/arch/hexagon/kernel/vdso.c
> index 6fd27ff1df73..8119084dc519 100644
> --- a/arch/hexagon/kernel/vdso.c
> +++ b/arch/hexagon/kernel/vdso.c
> @@ -54,7 +54,7 @@ int arch_setup_additional_pages(struct linux_binprm
> *bprm, int uses_interp)
>         struct vm_area_struct *vma;
>         struct mm_struct *mm = current->mm;
>         static struct vm_special_mapping vdso_mapping = {
> -               name = "[vdso]",
> +               .name = "[vdso]",
>         };
> 
>         if (mmap_write_lock_killable(mm))
> --
> 2.45.2
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-23 15:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 13:52 [PATCH] hexagon: vdso: Fix build failure Guenter Roeck
2024-09-23 15:14 ` Brian Cain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).