From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 27/33] dma-direct: use node local allocations for coherent memory Date: Wed, 10 Jan 2018 12:06:22 +0000 Message-ID: <3672aa56-b85c-5d2c-0c0e-709031b0c0a0@arm.com> References: <20180110080027.13879-1-hch@lst.de> <20180110080027.13879-28-hch@lst.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180110080027.13879-28-hch@lst.de> Content-Language: en-GB Sender: linux-m68k-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Christoph Hellwig , iommu@lists.linux-foundation.org Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Guan Xuetao , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, Konrad Rzeszutek Wilk , linux-snps-arc@lists.infradead.org, linux-m68k@lists.linux-m68k.org, patches@groups.riscv.org, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On 10/01/18 08:00, Christoph Hellwig wrote: > To preserve the x86 behavior. And combined with patch 10/22 of the SWIOTLB refactoring, this means SWIOTLB allocations will also end up NUMA-aware, right? Great, that's what we want on arm64 too :) Reviewed-by: Robin Murphy > Signed-off-by: Christoph Hellwig > --- > lib/dma-direct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/dma-direct.c b/lib/dma-direct.c > index a9ae98be7af3..f04a424f91fa 100644 > --- a/lib/dma-direct.c > +++ b/lib/dma-direct.c > @@ -38,7 +38,7 @@ static void *dma_direct_alloc(struct device *dev, size_t size, > if (gfpflags_allow_blocking(gfp)) > page = dma_alloc_from_contiguous(dev, count, page_order, gfp); > if (!page) > - page = alloc_pages(gfp, page_order); > + page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > if (!page) > return NULL; > >