From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Theodore Ts'o <tytso@mit.edu>, linux-hexagon@vger.kernel.org
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Richard Kuo <rkuo@codeaurora.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date: Fri, 21 Oct 2016 19:33:30 +0200 [thread overview]
Message-ID: <48d54097-6be3-d39d-2af9-d4ad90c3c417@users.sourceforge.net> (raw)
In-Reply-To: <20161021154624.maiwbgjmzlzhin2l@thunk.org>
>> Is it really so difficult to interpret the suggested construction
>> of a single (and relatively small) format string?
>
> It's not so difficult, so much as it makes things worse. It's easier
> the way it originally was.
Thanks for your view on this refactoring approach.
> It might be interesting to see if the compiler could be taught
> to collapse the function calls,
How does this wish fit to your previous rejection?
> but (a) this isn't performance critical,
This can be.
> and (b) the number of bytes saved is really tiny.
I imagine that the corresponding code and data size reduction could
be occasionally useful, couldn't it?
> But at least if the compiler was doing the work, it would at least deal with
> it everywhere.
I would find such an optimisation possibility also nice.
Can it become acceptable to achieve a similar effect by the application
of scripts for the semantic patch language in the meantime?
Regards,
Markus
next prev parent reply other threads:[~2016-10-21 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 6:33 [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring
2016-10-21 7:20 ` Julia Lawall
2016-10-21 9:00 ` SF Markus Elfring
2016-10-21 15:46 ` Theodore Ts'o
2016-10-21 17:33 ` SF Markus Elfring [this message]
2016-10-21 17:53 ` Theodore Ts'o
2016-10-21 18:28 ` SF Markus Elfring
2016-10-21 18:50 ` SF Markus Elfring
2016-10-25 21:37 ` Richard Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48d54097-6be3-d39d-2af9-d4ad90c3c417@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox