* Re: [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h
2012-06-21 19:21 [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h Paul Bolle
@ 2012-06-21 19:46 ` Richard Kuo
2012-06-21 19:54 ` Chris Metcalf
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Richard Kuo @ 2012-06-21 19:46 UTC (permalink / raw)
To: Paul Bolle
Cc: Michal Marek, linux-kbuild, linux-hexagon, David Howells,
linux-am33-list, Chris Metcalf, linux-kernel
On Thu, Jun 21, 2012 at 09:21:06PM +0200, Paul Bolle wrote:
> mn10300 has a header (in its include/asm directory) that is a thin
> wrapper around asm-generic/ipc.h. This wrapper is useless, since that
> header doesn't exist. It is also unused (no file includes asm/ipc.h).
>
> hexagon and tile generate similar headers at build time (using a
> generic-y entry in include/asm/Kbuild). These generated headers are
> useless and unused too.
>
> Remove this header and these generic-y entries.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> arch/hexagon/include/asm/Kbuild | 1 -
> arch/mn10300/include/asm/ipc.h | 1 -
> arch/tile/include/asm/Kbuild | 1 -
> 3 files changed, 0 insertions(+), 3 deletions(-)
> delete mode 100644 arch/mn10300/include/asm/ipc.h
>
> diff --git a/arch/hexagon/include/asm/Kbuild b/arch/hexagon/include/asm/Kbuild
> index 8ecd202..0690642 100644
> --- a/arch/hexagon/include/asm/Kbuild
> +++ b/arch/hexagon/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += ioctl.h
> generic-y += ioctls.h
> generic-y += iomap.h
> generic-y += ipcbuf.h
> -generic-y += ipc.h
> generic-y += irq_regs.h
> generic-y += kdebug.h
> generic-y += kmap_types.h
> diff --git a/arch/mn10300/include/asm/ipc.h b/arch/mn10300/include/asm/ipc.h
> deleted file mode 100644
> index a46e3d9..0000000
> --- a/arch/mn10300/include/asm/ipc.h
> +++ /dev/null
> @@ -1 +0,0 @@
> -#include <asm-generic/ipc.h>
> diff --git a/arch/tile/include/asm/Kbuild b/arch/tile/include/asm/Kbuild
> index 143473e..ab7640a 100644
> --- a/arch/tile/include/asm/Kbuild
> +++ b/arch/tile/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += fb.h
> generic-y += fcntl.h
> generic-y += ioctl.h
> generic-y += ioctls.h
> -generic-y += ipc.h
> generic-y += ipcbuf.h
> generic-y += irq_regs.h
> generic-y += kdebug.h
> --
> 1.7.7.6
>
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h
2012-06-21 19:21 [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h Paul Bolle
2012-06-21 19:46 ` Richard Kuo
@ 2012-06-21 19:54 ` Chris Metcalf
2012-06-21 23:08 ` David Howells
2012-06-28 9:30 ` Michal Marek
3 siblings, 0 replies; 5+ messages in thread
From: Chris Metcalf @ 2012-06-21 19:54 UTC (permalink / raw)
To: Paul Bolle
Cc: Michal Marek, linux-kbuild, Richard Kuo, linux-hexagon,
David Howells, linux-am33-list, linux-kernel
On 6/21/2012 3:21 PM, Paul Bolle wrote:
> mn10300 has a header (in its include/asm directory) that is a thin
> wrapper around asm-generic/ipc.h. This wrapper is useless, since that
> header doesn't exist. It is also unused (no file includes asm/ipc.h).
>
> hexagon and tile generate similar headers at build time (using a
> generic-y entry in include/asm/Kbuild). These generated headers are
> useless and unused too.
>
> Remove this header and these generic-y entries.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> arch/hexagon/include/asm/Kbuild | 1 -
> arch/mn10300/include/asm/ipc.h | 1 -
> arch/tile/include/asm/Kbuild | 1 -
> 3 files changed, 0 insertions(+), 3 deletions(-)
> delete mode 100644 arch/mn10300/include/asm/ipc.h
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
I can queue the tile change if you'd like; otherwise I assume you'll push
this whole commit.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h
2012-06-21 19:21 [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h Paul Bolle
2012-06-21 19:46 ` Richard Kuo
2012-06-21 19:54 ` Chris Metcalf
@ 2012-06-21 23:08 ` David Howells
2012-06-28 9:30 ` Michal Marek
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2012-06-21 23:08 UTC (permalink / raw)
To: Paul Bolle
Cc: dhowells, Michal Marek, linux-kbuild, Richard Kuo, linux-hexagon,
linux-am33-list, Chris Metcalf, linux-kernel
Paul Bolle <pebolle@tiscali.nl> wrote:
> mn10300 has a header (in its include/asm directory) that is a thin
> wrapper around asm-generic/ipc.h. This wrapper is useless, since that
> header doesn't exist. It is also unused (no file includes asm/ipc.h).
>
> hexagon and tile generate similar headers at build time (using a
> generic-y entry in include/asm/Kbuild). These generated headers are
> useless and unused too.
>
> Remove this header and these generic-y entries.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: David Howells <dhowells@redhat.com> [MN10300]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h
2012-06-21 19:21 [PATCH 2/3] Remove useless wrappers of asm-generic/ipc.h Paul Bolle
` (2 preceding siblings ...)
2012-06-21 23:08 ` David Howells
@ 2012-06-28 9:30 ` Michal Marek
3 siblings, 0 replies; 5+ messages in thread
From: Michal Marek @ 2012-06-28 9:30 UTC (permalink / raw)
To: Paul Bolle
Cc: linux-kbuild, Richard Kuo, linux-hexagon, David Howells,
linux-am33-list, Chris Metcalf, linux-kernel
On 21.6.2012 21:21, Paul Bolle wrote:
> mn10300 has a header (in its include/asm directory) that is a thin
> wrapper around asm-generic/ipc.h. This wrapper is useless, since that
> header doesn't exist. It is also unused (no file includes asm/ipc.h).
>
> hexagon and tile generate similar headers at build time (using a
> generic-y entry in include/asm/Kbuild). These generated headers are
> useless and unused too.
>
> Remove this header and these generic-y entries.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied to kbuild.git#trivial.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread