From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Kuo Subject: Re: [PATCH 1/2] hexagon: fix return type of ffs() Date: Wed, 14 Aug 2013 11:06:07 -0500 Message-ID: <520BAAEF.80100@codeaurora.org> References: <1375882959-26853-1-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1375882959-26853-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com, linux-hexagon@vger.kernel.org, linux-arch@vger.kernel.org On 08/07/2013 08:42 AM, Akinobu Mita wrote: > The return type of ffs() is 'int' on all architectures except cris and > hexagon. This unifies the return type to 'int'. > > The problem I'm seeing is that the following line generates a warning > on cris and hexagon because of the mismatch between format '%u' and > return type of ffs(). > > printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1); > > But removing this warning by casting to 'int' looks odd, so I suggest > unifying the return type of ffs() on all architectures. > > Signed-off-by: Akinobu Mita > Reported-by: Fengguang Wu > Cc: Mikael Starvik > Cc: Jesper Nilsson > Cc: linux-cris-kernel@axis.com > Cc: Richard Kuo > Cc: linux-hexagon@vger.kernel.org > Cc: linux-arch@vger.kernel.org > --- > This patch is not compile tested yet, because I couldn't find cross > compiler for hexagon. > > arch/hexagon/include/asm/bitops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/hexagon/include/asm/bitops.h b/arch/hexagon/include/asm/bitops.h > index 9b1e4af..80e34a6 100644 > --- a/arch/hexagon/include/asm/bitops.h > +++ b/arch/hexagon/include/asm/bitops.h > @@ -234,7 +234,7 @@ static inline long fls(int x) > * the libc and compiler builtin ffs routines, therefore > * differs in spirit from the above ffz (man ffs). > */ > -static inline long ffs(int x) > +static inline int ffs(int x) > { > int r; > For Hexagon: Acked-by: Richard Kuo -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation