* [PATCH] arch: hexagon: kernel: reset.c: use function pointer instead of function for pm_power_off and export it
@ 2013-11-29 4:01 Chen Gang
2013-12-06 18:23 ` rkuo
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2013-11-29 4:01 UTC (permalink / raw)
To: Richard Kuo; +Cc: linux-hexagon, linux-kernel@vger.kernel.org
'pm_power_off' is a function pointer, not a function, so need change
its type, and also need export it, or can not pass compiling with
allmodconfig. The related error:
MODPOST 2879 modules
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/hexagon/kernel/reset.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/hexagon/kernel/reset.c b/arch/hexagon/kernel/reset.c
index 6aeabc9..76483c1 100644
--- a/arch/hexagon/kernel/reset.c
+++ b/arch/hexagon/kernel/reset.c
@@ -33,6 +33,5 @@ void machine_restart(char *cmd)
{
}
-void pm_power_off(void)
-{
-}
+void (*pm_power_off)(void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arch: hexagon: kernel: reset.c: use function pointer instead of function for pm_power_off and export it
2013-11-29 4:01 [PATCH] arch: hexagon: kernel: reset.c: use function pointer instead of function for pm_power_off and export it Chen Gang
@ 2013-12-06 18:23 ` rkuo
0 siblings, 0 replies; 2+ messages in thread
From: rkuo @ 2013-12-06 18:23 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-hexagon, linux-kernel@vger.kernel.org
On Fri, Nov 29, 2013 at 12:01:37PM +0800, Chen Gang wrote:
> 'pm_power_off' is a function pointer, not a function, so need change
> its type, and also need export it, or can not pass compiling with
> allmodconfig. The related error:
>
> MODPOST 2879 modules
> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/hexagon/kernel/reset.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-06 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-29 4:01 [PATCH] arch: hexagon: kernel: reset.c: use function pointer instead of function for pm_power_off and export it Chen Gang
2013-12-06 18:23 ` rkuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).