[PATCH v2] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[PATCH v2] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[Chen Gang]

Need export all related functions and symbols for various modules with
allmodconfig. The related errors:

    MODPOST 2879 modules
  ERROR: "__vmyield" [sound/sound_firmware.ko] undefined!
  ERROR: "__phys_offset" [sound/drivers/snd-dummy.ko] undefined!
  ERROR: "ioremap_nocache" [drivers/char/ipmi/ipmi_si.ko] undefined!
  ERROR: "__iounmap" [drivers/char/ipmi/ipmi_si.ko] undefined!
  ...

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/hexagon/kernel/hexagon_ksyms.c |   27 +++++++++++++++++++++++----
 1 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c
index 32b1379..3188de4 100644
--- a/arch/hexagon/kernel/hexagon_ksyms.c
+++ b/arch/hexagon/kernel/hexagon_ksyms.c
@@ -20,6 +20,9 @@
 
 #include <asm/hexagon_vm.h>
 #include <asm/uaccess.h>
+#include <asm/io.h>
+#include <linux/dma-mapping.h>
+#include <asm/dma-mapping.h>
 
 EXPORT_SYMBOL(__copy_from_user_hexagon);
 EXPORT_SYMBOL(__copy_to_user_hexagon);
@@ -28,13 +31,29 @@ EXPORT_SYMBOL(__vmsetie);
 EXPORT_SYMBOL(memcpy);
 EXPORT_SYMBOL(memset);
 
+/* Additional functions */
+EXPORT_SYMBOL(__strnlen_user);
+EXPORT_SYMBOL(__vmyield);
+EXPORT_SYMBOL(__iounmap);
+EXPORT_SYMBOL(__clear_user_hexagon);
+EXPORT_SYMBOL(ioremap_nocache);
+EXPORT_SYMBOL(empty_zero_page);
+
+/* Additional variables */
+EXPORT_SYMBOL(_dflt_cache_att);
+EXPORT_SYMBOL(__phys_offset);
+EXPORT_SYMBOL(bad_dma_address);
+
 #define DECLARE_EXPORT(name)     \
 	extern void name(void); EXPORT_SYMBOL(name)
 
 /* Symbols found in libgcc that assorted kernel modules need */
 DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes);
 
-DECLARE_EXPORT(__hexagon_divsi3);
-DECLARE_EXPORT(__hexagon_modsi3);
-DECLARE_EXPORT(__hexagon_udivsi3);
-DECLARE_EXPORT(__hexagon_umodsi3);
+DECLARE_EXPORT(__divsi3);
+DECLARE_EXPORT(__modsi3);
+DECLARE_EXPORT(__udivsi3);
+DECLARE_EXPORT(__umodsi3);
+
+/* Additional functions */
+DECLARE_EXPORT(csum_tcpudp_magic);
-- 
1.7.7.6

Re: [PATCH v2] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[Chen Gang]

After this patch, excluding the VGA_CONSOLE issue, the hexagon can pass
allmodconfig. :-)

Please help check all related patches when you have time.


Thanks.

On 11/29/2013 12:01 PM, Chen Gang wrote:
> Need export all related functions and symbols for various modules with
> allmodconfig. The related errors:
> 
>     MODPOST 2879 modules
>   ERROR: "__vmyield" [sound/sound_firmware.ko] undefined!
>   ERROR: "__phys_offset" [sound/drivers/snd-dummy.ko] undefined!
>   ERROR: "ioremap_nocache" [drivers/char/ipmi/ipmi_si.ko] undefined!
>   ERROR: "__iounmap" [drivers/char/ipmi/ipmi_si.ko] undefined!
>   ...
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/hexagon/kernel/hexagon_ksyms.c |   27 +++++++++++++++++++++++----
>  1 files changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c
> index 32b1379..3188de4 100644
> --- a/arch/hexagon/kernel/hexagon_ksyms.c
> +++ b/arch/hexagon/kernel/hexagon_ksyms.c
> @@ -20,6 +20,9 @@
>  
>  #include <asm/hexagon_vm.h>
>  #include <asm/uaccess.h>
> +#include <asm/io.h>
> +#include <linux/dma-mapping.h>
> +#include <asm/dma-mapping.h>
>  
>  EXPORT_SYMBOL(__copy_from_user_hexagon);
>  EXPORT_SYMBOL(__copy_to_user_hexagon);
> @@ -28,13 +31,29 @@ EXPORT_SYMBOL(__vmsetie);
>  EXPORT_SYMBOL(memcpy);
>  EXPORT_SYMBOL(memset);
>  
> +/* Additional functions */
> +EXPORT_SYMBOL(__strnlen_user);
> +EXPORT_SYMBOL(__vmyield);
> +EXPORT_SYMBOL(__iounmap);
> +EXPORT_SYMBOL(__clear_user_hexagon);
> +EXPORT_SYMBOL(ioremap_nocache);
> +EXPORT_SYMBOL(empty_zero_page);
> +
> +/* Additional variables */
> +EXPORT_SYMBOL(_dflt_cache_att);
> +EXPORT_SYMBOL(__phys_offset);
> +EXPORT_SYMBOL(bad_dma_address);
> +
>  #define DECLARE_EXPORT(name)     \
>  	extern void name(void); EXPORT_SYMBOL(name)
>  
>  /* Symbols found in libgcc that assorted kernel modules need */
>  DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes);
>  
> -DECLARE_EXPORT(__hexagon_divsi3);
> -DECLARE_EXPORT(__hexagon_modsi3);
> -DECLARE_EXPORT(__hexagon_udivsi3);
> -DECLARE_EXPORT(__hexagon_umodsi3);
> +DECLARE_EXPORT(__divsi3);
> +DECLARE_EXPORT(__modsi3);
> +DECLARE_EXPORT(__udivsi3);
> +DECLARE_EXPORT(__umodsi3);
> +
> +/* Additional functions */
> +DECLARE_EXPORT(csum_tcpudp_magic);
> 


-- 
Chen Gang

[PATCH v3] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[Chen Gang]

Need export all related functions and symbols for various modules with
allmodconfig. The related errors:

    MODPOST 2879 modules
  ERROR: "__vmyield" [sound/sound_firmware.ko] undefined!
  ERROR: "__phys_offset" [sound/drivers/snd-dummy.ko] undefined!
  ERROR: "ioremap_nocache" [drivers/char/ipmi/ipmi_si.ko] undefined!
  ERROR: "__iounmap" [drivers/char/ipmi/ipmi_si.ko] undefined!
  ...

For including files, need "linux/*" first, then "asm/*". All related
included files and symbols need be sorted by alphabetical order.


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/hexagon/kernel/hexagon_ksyms.c | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c
index 32b1379..c041d8e 100644
--- a/arch/hexagon/kernel/hexagon_ksyms.c
+++ b/arch/hexagon/kernel/hexagon_ksyms.c
@@ -18,23 +18,39 @@
  * 02110-1301, USA.
  */
 
+#include <linux/dma-mapping.h>
 #include <asm/hexagon_vm.h>
+#include <asm/io.h>
 #include <asm/uaccess.h>
 
+/* Additional functions */
+EXPORT_SYMBOL(__clear_user_hexagon);
 EXPORT_SYMBOL(__copy_from_user_hexagon);
 EXPORT_SYMBOL(__copy_to_user_hexagon);
+EXPORT_SYMBOL(__iounmap);
+EXPORT_SYMBOL(__strnlen_user);
 EXPORT_SYMBOL(__vmgetie);
 EXPORT_SYMBOL(__vmsetie);
+EXPORT_SYMBOL(__vmyield);
+EXPORT_SYMBOL(empty_zero_page);
+EXPORT_SYMBOL(ioremap_nocache);
 EXPORT_SYMBOL(memcpy);
 EXPORT_SYMBOL(memset);
 
+/* Additional variables */
+EXPORT_SYMBOL(__phys_offset);
+EXPORT_SYMBOL(_dflt_cache_att);
+EXPORT_SYMBOL(bad_dma_address);
+
 #define DECLARE_EXPORT(name)     \
 	extern void name(void); EXPORT_SYMBOL(name)
 
 /* Symbols found in libgcc that assorted kernel modules need */
 DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes);
 
-DECLARE_EXPORT(__hexagon_divsi3);
-DECLARE_EXPORT(__hexagon_modsi3);
-DECLARE_EXPORT(__hexagon_udivsi3);
-DECLARE_EXPORT(__hexagon_umodsi3);
+/* Additional functions */
+DECLARE_EXPORT(__divsi3);
+DECLARE_EXPORT(__modsi3);
+DECLARE_EXPORT(__udivsi3);
+DECLARE_EXPORT(__umodsi3);
+DECLARE_EXPORT(csum_tcpudp_magic);
-- 
1.7.11.7

Re: [PATCH v3] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[rkuo]

On Tue, Dec 03, 2013 at 08:26:46PM +0800, Chen Gang wrote:
> Need export all related functions and symbols for various modules with
> allmodconfig. The related errors:
> 
>     MODPOST 2879 modules
>   ERROR: "__vmyield" [sound/sound_firmware.ko] undefined!
>   ERROR: "__phys_offset" [sound/drivers/snd-dummy.ko] undefined!
>   ERROR: "ioremap_nocache" [drivers/char/ipmi/ipmi_si.ko] undefined!
>   ERROR: "__iounmap" [drivers/char/ipmi/ipmi_si.ko] undefined!
>   ...
> 
> For including files, need "linux/*" first, then "asm/*". All related
> included files and symbols need be sorted by alphabetical order.
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/hexagon/kernel/hexagon_ksyms.c | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
> 

OK, hopefully I didn't leave anything out, but I'll try to upstream the
patches with my tree hopefully in the next window.  Thanks!

Acked-by: Richard Kuo <rkuo@codeaurora.org>

-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH v3] arch: hexagon: kernel: hexagon_ksyms.c: export related symbols which various modules need

[Chen Gang]

On 12/07/2013 02:25 AM, rkuo wrote:
> On Tue, Dec 03, 2013 at 08:26:46PM +0800, Chen Gang wrote:
>> Need export all related functions and symbols for various modules with
>> allmodconfig. The related errors:
>>
>>     MODPOST 2879 modules
>>   ERROR: "__vmyield" [sound/sound_firmware.ko] undefined!
>>   ERROR: "__phys_offset" [sound/drivers/snd-dummy.ko] undefined!
>>   ERROR: "ioremap_nocache" [drivers/char/ipmi/ipmi_si.ko] undefined!
>>   ERROR: "__iounmap" [drivers/char/ipmi/ipmi_si.ko] undefined!
>>   ...
>>
>> For including files, need "linux/*" first, then "asm/*". All related
>> included files and symbols need be sorted by alphabetical order.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  arch/hexagon/kernel/hexagon_ksyms.c | 24 ++++++++++++++++++++----
>>  1 file changed, 20 insertions(+), 4 deletions(-)
>>
> 
> OK, hopefully I didn't leave anything out, but I'll try to upstream the
> patches with my tree hopefully in the next window.  Thanks!
> 

Thank you very much !


> Acked-by: Richard Kuo <rkuo@codeaurora.org>
> 

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water and life which God blessed