From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2 9/9] efi: move screen_info into efi init code Date: Wed, 19 Jul 2023 16:35:34 +0200 Message-ID: <874jm0hsuh.fsf@minerva.mail-host-address-is-not-set> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-10-arnd@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0yR2pETHpvoCxjhuTQ6BY3WvX1lOuzTYu5NNEoCacNE=; b=IcCs1h/01aGdW+ s3z3IE/gfHo3pNhIkcR7NJ98fqXOAKXPEr8+AltpXDZjGMJNXvJWZt1Pmg9MZ1JoLUUIPf1D5YxJF lworwk99eaGKre6DborrcegBlV3a5WHX4ujcwbgAZ+aMC4swQPbLYWtq21zNpnNTkUlr3+rjL6EwT q1xQO+zq7UbnZ68Xo1aTRitO4MIxzV61UWwlJ7OYi3jzv7Dk+LWlbtGb3m9y2cF4GUONO/vlBrzy8 Yji4UVzK5t0ysXqWfwZXfa4KcRDVadUu7zok6063eajS0u1Uwm6guOiQTEvrpU7+Qw0DVSriyigEO 2t0IeSQc6iYsxCDvzV+w==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689777338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GW017PQkbwcyBZVSjL1eIJ3Tr23afBwEJMZO/sY3MB8=; b=Bk+dk1mBEQJDTKuW9K8t8hp3CB+h01vAXtIZOhfUUaOwjhn9QZJr3CrmMjGOtTHDmM5KZW vSQUlLA10dA9WKF3pWrhH871D3hn+/HeD7aooccGEqHBD5haE3RVpCeBrHeqIAGuJObE5/ sZCUoatdaCiRxEVTfL/SXBzjE87DKv8= In-Reply-To: <20230719123944.3438363-10-arnd@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Arnd Bergmann writes: > From: Arnd Bergmann > > After the vga console no longer relies on global screen_info, there are > only two remaining use cases: > > - on the x86 architecture, it is used for multiple boot methods > (bzImage, EFI, Xen, kexec) to commicate the initial VGA or framebuffer communicate > settings to a number of device drivers. > > - on other architectures, it is only used as part of the EFI stub, > and only for the three sysfb framebuffers (simpledrm, simplefb, efifb). > > Remove the duplicate data structure definitions by moving it into the > efi-init.c file that sets it up initially for the EFI case, leaving x86 > as an exception that retains its own definition for non-EFI boots. > > The added #ifdefs here are optional, I added them to further limit the > reach of screen_info to configurations that have at least one of the > users enabled. > > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat