From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2 7/9] vga16fb: drop powerpc support Date: Wed, 19 Jul 2023 16:23:53 +0200 Message-ID: <87a5vshtdy.fsf@minerva.mail-host-address-is-not-set> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-8-arnd@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qTjRvb/QfLNjpRtNxlWBHMNJQEzP06trON4PO57jwaw=; b=GDCtDZhcyXEJic +5Jb7MrSLwUt5bK0ZhCDUixVmw0+02WDBieEXKynpl6XoGLGnDAFdCLyX6TVrUJb1UlcvTObG/QBI e8kxcSMARX0cFcTWNmDmFkC/HLRPZbrz6BnRuUCO7Dx5cox/e4J//TF6A2R6ZbykAGr1wqWJ+FK1J vVLFjmTzUMGY+cQhcDP+mxsKgHKKKsilpBX9ebr053jMLWJVfSV1OF/I8PUjM2Af4as73g7wtCmiU ckHnPQ/MiKkeuJOAJdOs0EMp+Td4uY4EA0VWeX/oFEiad5YPCYJlvOklYGhZ05nxC65EXgRZvIMp/ WQhVyvgqIP1Vzb1M8nZg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689776639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AYL0WxfELPHjwx6ZiDqavEiQQIijrcopNRfhrvLV03A=; b=DGl5JY9HyulFIN/2+f+illzXjr1CUuSPQJD1122DRrwP6xZ92xeN2pjhyAJKxa+HgV3FIl MynIC41Cm5gBRFdGnOCNo1AIeuuXPtrvlxSorh2+q4UwJ7JZyfc3uHorXVkAiFh5mHtz0H ecT14gFgxtldx91wuKFNLDzERZKBYqE= In-Reply-To: <20230719123944.3438363-8-arnd@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org To: Arnd Bergmann , linux-fbdev@vger.kernel.org, Thomas Zimmermann , Helge Deller Cc: Arnd Bergmann , "David S. Miller" , "K. Y. Srinivasan" , Ard Biesheuvel , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Daniel Vetter , Dave Hansen , David Airlie , Deepak Rawat , Dexuan Cui , Dinh Nguyen , Greg Kroah-Hartman , Guo Ren , Haiyang Zhang , Huacai Chen , Ingo Molnar , John Paul Adrian Glaubitz , Khalid Aziz , Linus Walleij , Matt Turner , Max Arnd Bergmann writes: > From: Arnd Bergmann > > I noticed that commit 0db5b61e0dc07 ("fbdev/vga16fb: Create > EGA/VGA devices in sysfb code") broke vga16fb on non-x86 platforms, > because the sysfb code never creates a vga-framebuffer device when > screen_info.orig_video_isVGA is set to '1' instead of VIDEO_TYPE_VGAC. > > However, it turns out that the only architecture that has allowed > building vga16fb in the past 20 years is powerpc, and this only worked > on two 32-bit platforms and never on 64-bit powerpc. The last machine > that actually used this was removed in linux-3.10, so this is all dead > code and can be removed. > > The big-endian support in vga16fb.c could also be removed, but I'd just > leave this in place. > > Fixes: 933ee7119fb14 ("powerpc: remove PReP platform") > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat