From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arnd Bergmann" Subject: Re: [PATCH v3 2/2] arch/*/io.h: remove ioremap_uc in some architectures Date: Tue, 07 Mar 2023 08:17:30 +0100 Message-ID: <9d8292ad-c865-4b82-b6e3-d7db75820d0f@app.fastmail.com> References: <20230303102817.212148-1-bhe@redhat.com> <20230303102817.212148-3-bhe@redhat.com> <87sfej1rie.fsf@mpe.ellerman.id.au> <5dec69d0-0bc9-4f6c-8d0d-ee5422783100@app.fastmail.com> <87jzzt1ioc.fsf@mpe.ellerman.id.au> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678173473; x=1678259873; bh=qEXKdcaZZ2RtX2iYZ7qIlOWk0bUKh5e0zsP y9GctdU4=; b=EVRS9l0SgvuuYtQJV4VfCOBDd5P19/ufqL/xok5l9oWD530qvRl 32OGHmJT2bayLahPVS0gWRhnLxK6Z+Jlk++srAgloB6tZ4t6RnEQYl9dtmHEbUEF 41yZP0BmrDRa116+CrN+4XevwsaS770TCHXUy+xB6oK0X09IiOjiuVuH0C/ARmo6 fO6SZlgLkFxz5cjkZRClchxi0pyAZ+FHLG3nl/CBKqBfT5jRISfkTQNn0YYywD4T Wj92noz9HFGKpzdsy/cwomQIzdk3+YO7/KK9SAc605foLfc32u4qJDvXpP1n5P7c peGtwY/JqW+0XBFgu8QLiruwVmEZvdvu2Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678173473; x=1678259873; bh=qEXKdcaZZ2RtX2iYZ7qIlOWk0bUKh5e0zsP y9GctdU4=; b=drzmil3385Lov2w7beShJrFQ3GATqdBgomeK+nZBz6RibzrgaH9 Ph4oAZFDXe1gA4dz02jni1x8rYLPU8csmNt0y/kcxAHHuEqFKFb3SExrpsrl2+ox U3hGgfD2s/cIMt8ObvuYqHtHz6rCzw4uyLsanVK3GWvMbQj1h7ydE9biXdh6IlAo vbBrXEwKvNYO63OEEXlqSJsO+MvOnXKAazVOsOpMwDKqVBcWpraKL3cF2FUOLPH8 UeMggh88CpSEmj+eZVgGHUKWgsHEc9fW6HXemWUPFDglt5cDYOzE/+dXaTvRkKAT +fxjvbLqJBJC5gz7jKtljcIml1zGKCfQHUA== In-Reply-To: List-ID: Content-Type: text/plain; charset="windows-1252" To: Baoquan He , Michael Ellerman Cc: Geert Uytterhoeven , Linux-Arch , linux-sh@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Luis Chamberlain , linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Tue, Mar 7, 2023, at 02:30, Baoquan He wrote: > On 03/07/23 at 11:58am, Michael Ellerman wrote: >> "Arnd Bergmann" writes: >> > On Sun, Mar 5, 2023, at 10:29, Geert Uytterhoeven wrote: >> >> On Sun, Mar 5, 2023 at 10:23=E2=80=AFAM Michael Ellerman wrote: >> >>> Maybe that exact code path is only reachable on x86/ia64? But if = so >> >>> please explain why. >> >>> >> >>> Otherwise it looks like this series could break that driver on po= werpc >> >>> at least. >> >> >> >> Indeed. >> > >> > When I last looked into this, I sent a patch to use ioremap() >> > on non-x86: >> > >> > https://lore.kernel.org/all/20191111192258.2234502-1-arnd@arndb.de/ >>=20 >> OK thanks. >>=20 >> Baoquan can you add that patch to the start of this series if/when you >> post the next version? > > Sure, will do. Wondering if we need make change to cover powerpc other > than x86 and ia64 in Arnd's patch as you and Geert pointed out. The patch fixes the aty driver for all architectures, including the ones that were already broken before your series with the 'return NULL' version. The only other callers of ioremap_uc() and devm_ioremap_uc() are in architecture specific code and in drivers/mfd/intel-lpss.c, which is x86 specific. Arnd