Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly

[Lennox Wu <lennox.wu@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3012 bytes --]

I don't think it's necessary, what's the benfit?




2014-08-15 2:21 GMT+08:00 Vineet Gupta <Vineet.Gupta1@synopsys.com>:

> On Thursday 14 August 2014 09:55 AM, Chen Gang wrote:
> > Normal architectures:
> >
> >  - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc
> >
> >  - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300,
> >                   score, unicore32, x86
> >
> >  - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh
> >
> > Special architectures:
> >
> >  - Deside by compiler: microblaze, tile, xtensa.
> >
> >  - Deside by building host: um
> >
> >  - Next, need improve Kbuild to probe endian to deside whether need mark
> >    __BUILDING_TIME_BIG_ENDIAN__ before real config.
> >
> > Another improvements:
> >
> >  - score: use '\t' instead of ' '.
> >
> >  - s390: sort the select value in alpha order.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > ---
> >  arch/alpha/Kconfig      |  1 +
> >  arch/arc/Kconfig        |  1 +
> >  arch/arm/Kconfig        |  1 +
> >  arch/arm64/Kconfig      |  1 +
> >  arch/avr32/Kconfig      |  1 +
> >  arch/blackfin/Kconfig   |  1 +
> >  arch/c6x/Kconfig        |  1 +
> >  arch/cris/Kconfig       |  1 +
> >  arch/frv/Kconfig        |  1 +
> >  arch/hexagon/Kconfig    |  1 +
> >  arch/ia64/Kconfig       |  1 +
> >  arch/m32r/Kconfig       |  1 +
> >  arch/m68k/Kconfig       |  1 +
> >  arch/metag/Kconfig      |  1 +
> >  arch/microblaze/Kconfig |  2 ++
> >  arch/mips/Kconfig       |  1 +
> >  arch/mn10300/Kconfig    |  1 +
> >  arch/openrisc/Kconfig   |  1 +
> >  arch/parisc/Kconfig     |  1 +
> >  arch/powerpc/Kconfig    |  1 +
> >  arch/s390/Kconfig       |  3 ++-
> >  arch/score/Kconfig      | 21 +++++++++++----------
> >  arch/sparc/Kconfig      |  1 +
> >  arch/tile/Kconfig       |  2 ++
> >  arch/um/Kconfig.common  |  2 ++
> >  arch/unicore32/Kconfig  |  1 +
> >  arch/x86/Kconfig        |  1 +
> >  arch/xtensa/Kconfig     |  2 ++
> >  init/Kconfig            |  6 ++++++
> >  29 files changed, 49 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
> > index b7ff9a3..1cb7426 100644
> > --- a/arch/alpha/Kconfig
> > +++ b/arch/alpha/Kconfig
> > @@ -27,6 +27,7 @@ config ALPHA
> >       select MODULES_USE_ELF_RELA
> >       select ODD_RT_SIGACTION
> >       select OLD_SIGSUSPEND
> > +     select CPU_LITTLE_ENDIAN
> >       help
> >         The Alpha is a 64-bit general-purpose processor designed and
> >         marketed by the Digital Equipment Corporation of blessed memory,
> > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> > index 9596b0a..e939abd 100644
> > --- a/arch/arc/Kconfig
> > +++ b/arch/arc/Kconfig
> > @@ -35,6 +35,7 @@ config ARC
> >       select OF_EARLY_FLATTREE
> >       select PERF_USE_VMALLOC
> >       select HAVE_DEBUG_STACKOVERFLOW
> > +     select CPU_LITTLE_ENDIAN if !CPU_BIG_ENDIAN
>
> It is not clear what exactly are you trying to fix. What doesn't work w/o
> this
> patch !
>
> -Vineet
>

[-- Attachment #1.2: Type: text/html, Size: 4242 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev