linux-hexagon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unneeded include of version.h from arch/hexagon/include/asm/spinlock_types.h
@ 2011-11-20 20:59 Jesper Juhl
  2011-11-21 16:54 ` Linas Vepstas
  0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2011-11-20 20:59 UTC (permalink / raw)
  To: linux-hexagon; +Cc: Richard Kuo, Arnd Bergmann, linux-kernel

"make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
does not need to include version.h .
A quick look at the file seems to confirm its findings, so here's a patch that
removes the include.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 arch/hexagon/include/asm/spinlock_types.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

 Please note: I've not done any compile tests or other tests to confirm 
              this patch since I have no way to build stuff for this 
              architecture, so please review carefully before applying.

diff --git a/arch/hexagon/include/asm/spinlock_types.h b/arch/hexagon/include/asm/spinlock_types.h
index 5e937af..99b5a75 100644
--- a/arch/hexagon/include/asm/spinlock_types.h
+++ b/arch/hexagon/include/asm/spinlock_types.h
@@ -21,8 +21,6 @@
 #ifndef _ASM_SPINLOCK_TYPES_H
 #define _ASM_SPINLOCK_TYPES_H
 
-#include <linux/version.h>
-
 #ifndef __LINUX_SPINLOCK_TYPES_H
 # error "please don't include this file directly"
 #endif
-- 
1.7.7.3


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unneeded include of version.h from arch/hexagon/include/asm/spinlock_types.h
  2011-11-20 20:59 [PATCH] Remove unneeded include of version.h from arch/hexagon/include/asm/spinlock_types.h Jesper Juhl
@ 2011-11-21 16:54 ` Linas Vepstas
  0 siblings, 0 replies; 2+ messages in thread
From: Linas Vepstas @ 2011-11-21 16:54 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: linux-hexagon, Richard Kuo, Arnd Bergmann, linux-kernel

Acked-by: Linas Vepstas <linasvepstas@gmail.com>

On 20 November 2011 14:59, Jesper Juhl <jj@chaosbits.net> wrote:
> "make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
> does not need to include version.h .
> A quick look at the file seems to confirm its findings, so here's a patch that
> removes the include.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  arch/hexagon/include/asm/spinlock_types.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
>  Please note: I've not done any compile tests or other tests to confirm
>              this patch since I have no way to build stuff for this
>              architecture, so please review carefully before applying.
>
> diff --git a/arch/hexagon/include/asm/spinlock_types.h b/arch/hexagon/include/asm/spinlock_types.h
> index 5e937af..99b5a75 100644
> --- a/arch/hexagon/include/asm/spinlock_types.h
> +++ b/arch/hexagon/include/asm/spinlock_types.h
> @@ -21,8 +21,6 @@
>  #ifndef _ASM_SPINLOCK_TYPES_H
>  #define _ASM_SPINLOCK_TYPES_H
>
> -#include <linux/version.h>
> -
>  #ifndef __LINUX_SPINLOCK_TYPES_H
>  # error "please don't include this file directly"
>  #endif
> --
> 1.7.7.3
>
>
> --
> Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-21 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-20 20:59 [PATCH] Remove unneeded include of version.h from arch/hexagon/include/asm/spinlock_types.h Jesper Juhl
2011-11-21 16:54 ` Linas Vepstas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).