From: Christoph Hellwig <hch@infradead.org>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, hch@infradead.org,
agordeev@linux.ibm.com, wangkefeng.wang@huawei.com,
linux-arm-kernel@lists.infradead.org,
Brian Cain <bcain@quicinc.com>,
linux-hexagon@vger.kernel.org
Subject: Re: [PATCH v2 05/11] hexagon: mm: Convert to GENERIC_IOREMAP
Date: Sun, 21 Aug 2022 00:00:07 -0700 [thread overview]
Message-ID: <YwHX98KBEnZw9t6e@infradead.org> (raw)
In-Reply-To: <20220820003125.353570-6-bhe@redhat.com>
On Sat, Aug 20, 2022 at 08:31:19AM +0800, Baoquan He wrote:
> With it, the old ioremap() and iounmap() can be perfectly removed
> since they are duplicated with the standard functions.
Can you write a somewhat better commit message explaining that it
switches to the generic code that has equivalent functionality?
> +#define ioremap_uc(addr, size) ioremap((addr), (size))
This is wrong and hexagon should use the asm-generic version of
ioremap_uc that returns NULL.
next prev parent reply other threads:[~2022-08-21 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220820003125.353570-1-bhe@redhat.com>
2022-08-20 0:31 ` [PATCH v2 05/11] hexagon: mm: Convert to GENERIC_IOREMAP Baoquan He
2022-08-20 1:23 ` Brian Cain
2022-08-21 7:00 ` Christoph Hellwig [this message]
2022-08-28 15:08 ` Baoquan He
2022-08-22 6:38 ` Christophe Leroy
2022-08-28 15:12 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwHX98KBEnZw9t6e@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bcain@quicinc.com \
--cc=bhe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).