From mboxrd@z Thu Jan 1 00:00:00 1970 From: prarit (prarit@prarit.com) Date: Sun, 13 Mar 2005 00:49:42 +0000 Subject: Re: Re: Latest bk kernel does not properly free PCI IO & MEM Message-Id: <0ID9002ARMAUPH11@vms048.mailsrvcs.net> List-Id: References: <422F42A9.7050009@sgi.com> In-Reply-To: <422F42A9.7050009@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org > So running a UP kernel on your box doesn't cause any problems? Gee .. I haven't actually tried it :). That's probably a good test to run ... I'll try that first thing on Monday. > > Additionally, I've seen people using PCI Hotplug in the field. > > Typically when removing a card sysadmins tend to quiesce the system > > before removal. That makes #4 just that much less likely to occur. > > It's usually a good idea to do this :) > In some sense, yes. I would argue that it's not a PCI HotPlug issue, but a driver issue -- most of the drivers out there don't pay a lot of attention to the stability of the driver remove function :( I've seen all sorts of things in removes that are done wrong -- from not terminating timers, to not quiecing queues, to not properly kfree'ing memory. Qlogic drivers are especially bad :) ... That's why I hesitate to test with them in the system but in this case it was what was available to me. > > :) :) Want the long explanation? :) :) > > Sure... > I'll go back to work and pull out the oops' etc. > Anyway, I'll add the basic, NULL out the pointer and check for it patch > to the tree soon, so that your oops should not happen anymore. Thanks Greg :) I've tested with that patch and it seems better. IMO though, we still have a glitch in PCI. I'm not convinced that it should be calling pci_free_resources at all. > > thanks, > > greg k-h > Thanks, P. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel